From da9ffb8458d49b2f5710e1acd640b436d7163b3e Mon Sep 17 00:00:00 2001 From: Ionut Bajescu Date: Wed, 24 Feb 2021 15:05:49 +0000 Subject: [PATCH] Fix rest_client_rate_limiter_duration_seconds not registered We've found that the rate limiting metric wasn't exporting any metrics, in spite of clearly seeing the metric in the disassembled binary. As it turns out, the rest_client_rate_limiter_duration_seconds metric has been added as part of the logging improvements, but it appears to have been accidentally forgotten to be registered. https://github.com/kubernetes/kubernetes/pull/88134 --- .../component-base/metrics/prometheus/restclient/metrics.go | 1 + 1 file changed, 1 insertion(+) diff --git a/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go b/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go index 6125fee50e8..bb9087260ed 100644 --- a/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go +++ b/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go @@ -108,6 +108,7 @@ var ( func init() { legacyregistry.MustRegister(requestLatency) + legacyregistry.MustRegister(rateLimiterLatency) legacyregistry.MustRegister(requestResult) legacyregistry.RawMustRegister(execPluginCertTTL) legacyregistry.MustRegister(execPluginCertRotation)