From 08d4748de23039cd25b98a6e93f61b90877c59f9 Mon Sep 17 00:00:00 2001 From: chymy Date: Mon, 22 Aug 2022 02:56:35 +0000 Subject: [PATCH] kubeadm: add test cases for version_test.go Signed-off-by: chymy --- cmd/kubeadm/app/util/version_test.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cmd/kubeadm/app/util/version_test.go b/cmd/kubeadm/app/util/version_test.go index 4b9610650ec..8eb749c23a8 100644 --- a/cmd/kubeadm/app/util/version_test.go +++ b/cmd/kubeadm/app/util/version_test.go @@ -50,6 +50,7 @@ func TestValidVersion(t *testing.T) { "v1.5.0-alpha.0.1078+1044b6822497da-pull", "v1.5.0-alpha.1.822+49b9e32fad9f32-pull-gke-gci", "v1.6.1+coreos.0", + "1.7.1", } for _, s := range validVersions { t.Run(s, func(t *testing.T) { @@ -58,7 +59,7 @@ func TestValidVersion(t *testing.T) { if err != nil { t.Errorf("KubernetesReleaseVersion unexpected error for version %q: %v", s, err) } - if ver != s { + if ver != s && ver != "v"+s { t.Errorf("KubernetesReleaseVersion should return same valid version string. %q != %q", s, ver) } }) @@ -203,6 +204,9 @@ func TestSplitVersion(t *testing.T) { {"unknown-1", "https://dl.k8s.io/release", "unknown-1", true}, // unknown area, not valid input. {"unknown/latest-1", "", "", false}, + // invalid input + {"", "", "", false}, + {"ci/", "", "", false}, } for _, tc := range cases { @@ -235,6 +239,7 @@ func TestKubernetesIsCIVersion(t *testing.T) { // CI builds {"ci/latest-1", true}, {"ci/v1.9.0-alpha.1.123+acbcbfd53bfa0a", true}, + {"ci/", false}, } for _, tc := range cases { @@ -265,6 +270,7 @@ func TestCIBuildVersion(t *testing.T) { {"ci/v1.9.0-alpha.1.123+acbcbfd53bfa0a", "v1.9.0-alpha.1.123+acbcbfd53bfa0a", true}, {"ci/1.9.0-alpha.1.123+acbcbfd53bfa0a", "v1.9.0-alpha.1.123+acbcbfd53bfa0a", true}, {"ci/0invalid", "", false}, + {"0invalid", "", false}, } for _, tc := range cases {