github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #113212 from pohly/e2e-progress-on-stdout-removal

Browse Source 
e2e: remove JSON progress output on stdout
This commit is contained in:
Kubernetes Prow Robot 2022-10-20 10:29:12 -07:00 committed by GitHub
commit dbb3b4f340
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/e2e/reporters/progress.go
View File

@ -62,19 +62,19 @@ func NewProgressReporter(progressReportURL string) *ProgressReporter {
return rep return rep
} }
// SendUpdates serializes the current progress and prints it to stdout and also posts it to the configured endpoint if set. // SendUpdates serializes the current progress and posts it to the configured endpoint if set.
// It does not print to stdout because that interferes with progress reporting by Ginko
// and (when Ginkgo does output redirection) doesn't actually appear on the screen anyway.
func (reporter *ProgressReporter) SendUpdates() { func (reporter *ProgressReporter) SendUpdates() {
b := reporter.serialize()
fmt.Println(string(b))
go reporter.postProgressToURL(b)
}
func (reporter *ProgressReporter) postProgressToURL(b []byte) {
// If a progressURL and client is set/available then POST to it. Noop otherwise. // If a progressURL and client is set/available then POST to it. Noop otherwise.
if reporter.client == nil || len(reporter.progressURL) == 0 { if reporter.client == nil || len(reporter.progressURL) == 0 {
return return
} }
b := reporter.serialize()
go reporter.postProgressToURL(b)
}
func (reporter *ProgressReporter) postProgressToURL(b []byte) {
resp, err := reporter.client.Post(reporter.progressURL, "application/json", bytes.NewReader(b)) resp, err := reporter.client.Post(reporter.progressURL, "application/json", bytes.NewReader(b))
if err != nil { if err != nil {
klog.Errorf("Failed to post progress update to %v: %v", reporter.progressURL, err) klog.Errorf("Failed to post progress update to %v: %v", reporter.progressURL, err)