github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 03:57:41 +00:00
Code Issues Projects Releases Wiki Activity

kubelet: explicit variable names in Test_validateServices

Browse Source 
Signed-off-by: Stephen Kitt <skitt@redhat.com>
This commit is contained in:
Stephen Kitt 2024-10-03 11:45:55 +02:00
parent c6669ea7d6
commit dbfab994bf
No known key found for this signature in database
GPG Key ID: 1CC5FA453662A71D
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
pkg/kubelet/kubelet_server_journal_test.go
View File

@ -128,14 +128,14 @@ func Test_newNodeLogQuery(t *testing.T) {
func Test_validateServices(t *testing.T) { func Test_validateServices(t *testing.T) {
var ( var (
service1 = "svc1" service1 = "svc1"
service2 = "svc2" service2 = "svc2"
service3 = "svc.foo" serviceDot = "svc.foo"
service4 = "svc_foo" serviceUnderscore = "svc_foo"
service5 = "svc@foo" serviceAt = "svc@foo"
service6 = "svc:foo" serviceColon = "svc:foo"
invalid1 = "svc\n" invalidServiceNewline = "svc\n"
invalid2 = "svc.foo\n" invalidServiceNewlineDot = "svc.foo\n"
) )
tests := []struct { tests := []struct {
name string name string
@ -144,14 +144,14 @@ func Test_validateServices(t *testing.T) {
}{ }{
{name: "one service", services: []string{service1}}, {name: "one service", services: []string{service1}},
{name: "two services", services: []string{service1, service2}}, {name: "two services", services: []string{service1, service2}},
{name: "dot service", services: []string{service3}}, {name: "dot service", services: []string{serviceDot}},
{name: "underscore service", services: []string{service4}}, {name: "underscore service", services: []string{serviceUnderscore}},
{name: "at service", services: []string{service5}}, {name: "at service", services: []string{serviceAt}},
{name: "colon service", services: []string{service6}}, {name: "colon service", services: []string{serviceColon}},
{name: "invalid service new line", services: []string{invalid1}, wantErr: true}, {name: "invalid service new line", services: []string{invalidServiceNewline}, wantErr: true},
{name: "invalid service with dot", services: []string{invalid2}, wantErr: true}, {name: "invalid service with dot", services: []string{invalidServiceNewlineDot}, wantErr: true},
{name: "long service", services: []string{strings.Repeat(service1, 100)}, wantErr: true}, {name: "long service", services: []string{strings.Repeat(service1, 100)}, wantErr: true},
{name: "max number of services", services: []string{service1, service2, service3, service4, service5}, wantErr: true}, {name: "max number of services", services: []string{service1, service2, serviceDot, serviceUnderscore, serviceAt}, wantErr: true},
} }
for _, tt := range tests { for _, tt := range tests {
errs := validateServices(tt.services) errs := validateServices(tt.services)