github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Ensure that we are closing files.

Browse Source
This commit is contained in:
Piotr Skamruk 2016-09-06 09:58:22 +02:00
parent ff1cec99cc
commit dc3674c8d0
5 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
contrib/mesos/pkg/scheduler/service/service.go
View File

@ -612,6 +612,7 @@ func (s *SchedulerServer) Run(hks hyperkube.Interface, _ []string) error {
if err != nil { if err != nil {
log.Fatalf("Cannot open scheduler config file: %v", err) log.Fatalf("Cannot open scheduler config file: %v", err)
} }
defer f.Close()
err = sc.Read(bufio.NewReader(f)) err = sc.Read(bufio.NewReader(f))
if err != nil { if err != nil {

1
pkg/cloudprovider/providers/rackspace/rackspace.go
View File

@ -156,6 +156,7 @@ func readInstanceID() (string, error) {
if err != nil { if err != nil {
return "", fmt.Errorf("Cannot open %s: %v", metaDataPath, err) return "", fmt.Errorf("Cannot open %s: %v", metaDataPath, err)
} }
defer file.Close()
return parseMetaData(file) return parseMetaData(file)
} }

1
pkg/kubectl/cmd/apply_test.go
View File

@ -66,6 +66,7 @@ func readBytesFromFile(t *testing.T, filename string) []byte {
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
defer file.Close()
data, err := ioutil.ReadAll(file) data, err := ioutil.ReadAll(file)
if err != nil { if err != nil {

2
plugin/pkg/admission/imagepolicy/admission_test.go
View File

@ -242,6 +242,7 @@ current-context: default
if err != nil { if err != nil {
return fmt.Errorf("failed to read test config: %v", err) return fmt.Errorf("failed to read test config: %v", err)
} }
defer configFile.Close()
_, err = NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile) _, err = NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile)
return err return err
@ -402,6 +403,7 @@ func newImagePolicyWebhook(callbackURL string, clientCert, clientKey, ca []byte,
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to read test config: %v", err) return nil, fmt.Errorf("failed to read test config: %v", err)
} }
defer configFile.Close()
wh, err := NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile) wh, err := NewImagePolicyWebhook(fake.NewSimpleClientset(), configFile)
return wh.(*imagePolicyWebhook), err return wh.(*imagePolicyWebhook), err
} }

1
test/e2e/kubectl.go
View File

@ -1528,6 +1528,7 @@ func readBytesFromFile(filename string) []byte {
framework.Failf(err.Error()) framework.Failf(err.Error())
} }
defer file.Close() defer file.Close()
data, err := ioutil.ReadAll(file) data, err := ioutil.ReadAll(file)
if err != nil { if err != nil {
framework.Failf(err.Error()) framework.Failf(err.Error())