github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 21:17:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #105212 from BinacsLee/binacs-scheduler-do-not-reference-range-loop-vars

Browse Source 
scheduler: do not reference range-loop variable
This commit is contained in:
Kubernetes Prow Robot 2021-09-27 13:59:45 -07:00 committed by GitHub
commit dca007bac8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/scheduler/framework/types.go
View File

@ -273,8 +273,8 @@ func getAffinityTerms(pod *v1.Pod, v1Terms []v1.PodAffinityTerm) ([]AffinityTerm
} }
var terms []AffinityTerm var terms []AffinityTerm
for _, term := range v1Terms { for i := range v1Terms {
t, err := newAffinityTerm(pod, &term) t, err := newAffinityTerm(pod, &v1Terms[i])
if err != nil { if err != nil {
// We get here if the label selector failed to process // We get here if the label selector failed to process
return nil, err return nil, err
@ -291,13 +291,13 @@ func getWeightedAffinityTerms(pod *v1.Pod, v1Terms []v1.WeightedPodAffinityTerm)
} }
var terms []WeightedAffinityTerm var terms []WeightedAffinityTerm
for _, term := range v1Terms { for i := range v1Terms {
t, err := newAffinityTerm(pod, &term.PodAffinityTerm) t, err := newAffinityTerm(pod, &v1Terms[i].PodAffinityTerm)
if err != nil { if err != nil {
// We get here if the label selector failed to process // We get here if the label selector failed to process
return nil, err return nil, err
} }
terms = append(terms, WeightedAffinityTerm{AffinityTerm: *t, Weight: term.Weight}) terms = append(terms, WeightedAffinityTerm{AffinityTerm: *t, Weight: v1Terms[i].Weight})
} }
return terms, nil return terms, nil
} }