From dca79aadddf7be2570f637302e3e020f43ca156b Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Tue, 31 Jul 2018 19:04:31 -0400 Subject: [PATCH] Environment vars with newlines should be indented Break env var values with newlines so they form a consistent left alignment. --- pkg/printers/internalversion/describe.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/printers/internalversion/describe.go b/pkg/printers/internalversion/describe.go index f9399173bfd..85f65080e1e 100644 --- a/pkg/printers/internalversion/describe.go +++ b/pkg/printers/internalversion/describe.go @@ -1562,7 +1562,13 @@ func describeContainerEnvVars(container api.Container, resolverFn EnvVarResolver for _, e := range container.Env { if e.ValueFrom == nil { - w.Write(LEVEL_3, "%s:\t%s\n", e.Name, e.Value) + for i, s := range strings.Split(e.Value, "\n") { + if i == 0 { + w.Write(LEVEL_3, "%s:\t%s\n", e.Name, s) + } else { + w.Write(LEVEL_3, "\t%s\n", s) + } + } continue }