From 4c37faaaa7e8d01590baeb1fa9aee53e5e7891c4 Mon Sep 17 00:00:00 2001 From: Hemant Kumar Date: Wed, 14 Jun 2017 15:21:10 -0400 Subject: [PATCH] Deprecate keep-terminated-pod-volumes It was discussed and agreed by sig-storage that this flag causes unnecessary confusion and is hard to keep synchornized with controller's attach/detach functionality. --- cmd/kubelet/app/options/options.go | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/kubelet/app/options/options.go b/cmd/kubelet/app/options/options.go index 48f8d9b9fd3..6fe45712379 100644 --- a/cmd/kubelet/app/options/options.go +++ b/cmd/kubelet/app/options/options.go @@ -284,6 +284,7 @@ func (c *kubeletConfiguration) addFlags(fs *pflag.FlagSet) { fs.Int32Var(&c.PodsPerCore, "pods-per-core", c.PodsPerCore, "Number of Pods per core that can run on this Kubelet. The total number of Pods on this Kubelet cannot exceed max-pods, so max-pods will be used if this calculation results in a larger number of Pods allowed on the Kubelet. A value of 0 disables this limit.") fs.BoolVar(&c.ProtectKernelDefaults, "protect-kernel-defaults", c.ProtectKernelDefaults, "Default kubelet behaviour for kernel tuning. If set, kubelet errors if any of kernel tunables is different than kubelet defaults.") fs.BoolVar(&c.KeepTerminatedPodVolumes, "keep-terminated-pod-volumes", c.KeepTerminatedPodVolumes, "Keep terminated pod volumes mounted to the node after the pod terminates. Can be useful for debugging volume related issues.") + fs.MarkDeprecated("keep-terminated-pod-volumes", "will be removed in a future version") // CRI flags. fs.StringVar(&c.RemoteRuntimeEndpoint, "container-runtime-endpoint", c.RemoteRuntimeEndpoint, "[Experimental] The endpoint of remote runtime service. Currently unix socket is supported on Linux, and tcp is supported on windows. Examples:'unix:///var/run/dockershim.sock', 'tcp://localhost:3735'")