From 3c15fc0901f5a60639103f2280a8416e3ebe04d7 Mon Sep 17 00:00:00 2001 From: mqliang Date: Tue, 6 Oct 2015 10:49:17 +0800 Subject: [PATCH] use string constant instead of duplicating --- pkg/apis/experimental/validation/validation.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/apis/experimental/validation/validation.go b/pkg/apis/experimental/validation/validation.go index e72577d9cd1..04935c39027 100644 --- a/pkg/apis/experimental/validation/validation.go +++ b/pkg/apis/experimental/validation/validation.go @@ -54,7 +54,7 @@ func ValidateHorizontalPodAutoscalerName(name string, prefix bool) (bool, string func validateHorizontalPodAutoscalerSpec(autoscaler experimental.HorizontalPodAutoscalerSpec) errs.ValidationErrorList { allErrs := errs.ValidationErrorList{} if autoscaler.MinReplicas < 0 { - allErrs = append(allErrs, errs.NewFieldInvalid("minReplicas", autoscaler.MinReplicas, `must be non-negative`)) + allErrs = append(allErrs, errs.NewFieldInvalid("minReplicas", autoscaler.MinReplicas, isNegativeErrorMsg)) } if autoscaler.MaxReplicas < autoscaler.MinReplicas { allErrs = append(allErrs, errs.NewFieldInvalid("maxReplicas", autoscaler.MaxReplicas, `must be bigger or equal to minReplicas`)) @@ -68,7 +68,7 @@ func validateHorizontalPodAutoscalerSpec(autoscaler experimental.HorizontalPodAu } quantity := autoscaler.Target.Quantity.Value() if quantity < 0 { - allErrs = append(allErrs, errs.NewFieldInvalid("target.quantity", quantity, "must be non-negative")) + allErrs = append(allErrs, errs.NewFieldInvalid("target.quantity", quantity, isNegativeErrorMsg)) } return allErrs }