From acc55500bcca3ece1864069ddb6b9e42f3b11db6 Mon Sep 17 00:00:00 2001 From: shawnhanx Date: Sat, 13 Nov 2021 17:15:25 +0800 Subject: [PATCH] should omit comparison to bool constant in pkg/controller/controller_utils.go --- pkg/controller/controller_utils.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/controller/controller_utils.go b/pkg/controller/controller_utils.go index 62242617583..97f8a03c9c6 100644 --- a/pkg/controller/controller_utils.go +++ b/pkg/controller/controller_utils.go @@ -504,10 +504,10 @@ func validateControllerRef(controllerRef *metav1.OwnerReference) error { if len(controllerRef.Kind) == 0 { return fmt.Errorf("controllerRef has empty Kind") } - if controllerRef.Controller == nil || *controllerRef.Controller != true { + if controllerRef.Controller == nil || !*controllerRef.Controller { return fmt.Errorf("controllerRef.Controller is not set to true") } - if controllerRef.BlockOwnerDeletion == nil || *controllerRef.BlockOwnerDeletion != true { + if controllerRef.BlockOwnerDeletion == nil || !*controllerRef.BlockOwnerDeletion { return fmt.Errorf("controllerRef.BlockOwnerDeletion is not set") } return nil