github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 06:27:05 +00:00
Code Issues Projects Releases Wiki Activity

Use https when Insecure is selected.

Browse Source
This commit is contained in:
Eric Tune 2014-11-12 23:54:54 -08:00
parent 9f2750694c
commit dd3c85be09
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/client/helper.go
View File

@ -231,7 +231,7 @@ func IsConfigTransportSecure(config *Config) bool {
func defaultServerUrlFor(config *Config) (*url.URL, error) { func defaultServerUrlFor(config *Config) (*url.URL, error) {
version := defaultVersionFor(config) version := defaultVersionFor(config)
// TODO: move the default to secure when the apiserver supports TLS by default // TODO: move the default to secure when the apiserver supports TLS by default
defaultSecure := config.CertFile != "" defaultSecure := config.CertFile != "" || config.Insecure
host := config.Host host := config.Host
if host == "" { if host == "" {
host = "localhost" host = "localhost"

7
pkg/client/helper_test.go
View File

@ -76,6 +76,13 @@ func TestIsConfigTransportSecure(t *testing.T) {
}, },
Secure: false, Secure: false,
}, },
{
Config: &Config{
Host: "1.2.3.4:567",
Insecure: true,
},
Secure: true,
},
} }
for _, testCase := range testCases { for _, testCase := range testCases {
secure := IsConfigTransportSecure(testCase.Config) secure := IsConfigTransportSecure(testCase.Config)