From dd3eeb3f466d77405f3c2cc8d88851a1c57dc21d Mon Sep 17 00:00:00 2001 From: Ismo Puustinen Date: Tue, 21 Aug 2018 14:55:13 +0300 Subject: [PATCH] device manager: don't do operations on nil pointer. If grpc.DialContext() fails, a nil connection is returned. Check the error before calling conn.Close(). --- pkg/kubelet/cm/devicemanager/device_plugin_stub.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/cm/devicemanager/device_plugin_stub.go b/pkg/kubelet/cm/devicemanager/device_plugin_stub.go index 62072ba5559..d4040fd1ec9 100644 --- a/pkg/kubelet/cm/devicemanager/device_plugin_stub.go +++ b/pkg/kubelet/cm/devicemanager/device_plugin_stub.go @@ -165,10 +165,10 @@ func (m *Stub) Register(kubeletEndpoint, resourceName string, pluginSockDir stri grpc.WithDialer(func(addr string, timeout time.Duration) (net.Conn, error) { return net.DialTimeout("unix", addr, timeout) })) - defer conn.Close() if err != nil { return err } + defer conn.Close() client := pluginapi.NewRegistrationClient(conn) reqt := &pluginapi.RegisterRequest{ Version: pluginapi.Version,