From dd7ed11fc18a18fefcb01474831294bb2195d68b Mon Sep 17 00:00:00 2001 From: deads2k Date: Thu, 24 Sep 2015 12:53:33 -0400 Subject: [PATCH] don't fatal on missing sorting flag --- pkg/kubectl/cmd/util/printing.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/kubectl/cmd/util/printing.go b/pkg/kubectl/cmd/util/printing.go index 5205998e39a..3a4803d9cc2 100644 --- a/pkg/kubectl/cmd/util/printing.go +++ b/pkg/kubectl/cmd/util/printing.go @@ -112,7 +112,12 @@ func PrinterForCommand(cmd *cobra.Command) (kubectl.ResourcePrinter, bool, error } func maybeWrapSortingPrinter(cmd *cobra.Command, printer kubectl.ResourcePrinter) kubectl.ResourcePrinter { - sorting := GetFlagString(cmd, "sort-by") + sorting, err := cmd.Flags().GetString("sort-by") + if err != nil { + // error can happen on missing flag or bad flag type. In either case, this command didn't intent to sort + return printer + } + if len(sorting) != 0 { return &kubectl.SortingPrinter{ Delegate: printer,