diff --git a/test/e2e/apimachinery/crd_publish_openapi.go b/test/e2e/apimachinery/crd_publish_openapi.go index b2d2830106b..57b82312dd8 100644 --- a/test/e2e/apimachinery/crd_publish_openapi.go +++ b/test/e2e/apimachinery/crd_publish_openapi.go @@ -479,7 +479,7 @@ var _ = SIGDescribe("CustomResourcePublishOpenAPI [Privileged:ClusterAdmin]", fu }) // Marked as flaky until https://github.com/kubernetes/kubernetes/issues/65517 is solved. - ginkgo.It("[Flaky] kubectl explain works for CR with the same resource name as built-in object.", func(ctx context.Context) { + f.It(f.WithFlaky(), "kubectl explain works for CR with the same resource name as built-in object.", func(ctx context.Context) { customServiceShortName := fmt.Sprintf("ksvc-%d", time.Now().Unix()) // make short name unique opt := func(crd *apiextensionsv1.CustomResourceDefinition) { crd.ObjectMeta = metav1.ObjectMeta{Name: "services." + crd.Spec.Group} diff --git a/test/e2e/framework/ginkgowrapper.go b/test/e2e/framework/ginkgowrapper.go index a31d2c15d07..25710efefd3 100644 --- a/test/e2e/framework/ginkgowrapper.go +++ b/test/e2e/framework/ginkgowrapper.go @@ -248,7 +248,7 @@ func registerInSuite(ginkgoCall func(string, ...interface{}) bool, args []interf var ( tagRe = regexp.MustCompile(`\[.*?\]`) - deprecatedTags = sets.New("Conformance", "NodeConformance", "Disruptive", "Serial", "Slow") + deprecatedTags = sets.New("Conformance", "Flaky", "NodeConformance", "Disruptive", "Serial", "Slow") deprecatedTagPrefixes = sets.New("Environment", "Feature", "NodeFeature", "FeatureGate") deprecatedStability = sets.New("Alpha", "Beta") ) diff --git a/test/e2e/node/kubelet.go b/test/e2e/node/kubelet.go index ad4dda9f50f..ed5add50371 100644 --- a/test/e2e/node/kubelet.go +++ b/test/e2e/node/kubelet.go @@ -385,7 +385,7 @@ var _ = SIGDescribe("kubelet", func() { }) // Test host cleanup when disrupting the volume environment. - ginkgo.Describe("host cleanup with volume mounts [HostCleanup][Flaky]", func() { + f.Describe("host cleanup with volume mounts [HostCleanup]", f.WithFlaky(), func() { type hostCleanupTest struct { itDescr string diff --git a/test/e2e/node/security_context.go b/test/e2e/node/security_context.go index ce21a5d0c8c..b4ccd5d10ba 100644 --- a/test/e2e/node/security_context.go +++ b/test/e2e/node/security_context.go @@ -186,15 +186,15 @@ var _ = SIGDescribe("Security Context", func() { }) }) - ginkgo.It("should support volume SELinux relabeling [Flaky] [LinuxOnly]", func(ctx context.Context) { + f.It("should support volume SELinux relabeling", f.WithFlaky(), f.WithLabel("LinuxOnly"), func(ctx context.Context) { testPodSELinuxLabeling(ctx, f, false, false) }) - ginkgo.It("should support volume SELinux relabeling when using hostIPC [Flaky] [LinuxOnly]", func(ctx context.Context) { + f.It("should support volume SELinux relabeling when using hostIPC", f.WithFlaky(), f.WithLabel("LinuxOnly"), func(ctx context.Context) { testPodSELinuxLabeling(ctx, f, true, false) }) - ginkgo.It("should support volume SELinux relabeling when using hostPID [Flaky] [LinuxOnly]", func(ctx context.Context) { + f.It("should support volume SELinux relabeling when using hostPID", f.WithFlaky(), f.WithLabel("LinuxOnly"), func(ctx context.Context) { testPodSELinuxLabeling(ctx, f, false, true) }) diff --git a/test/e2e/storage/nfs_persistent_volume-disruptive.go b/test/e2e/storage/nfs_persistent_volume-disruptive.go index d5577b06c6a..003c8ae6a4d 100644 --- a/test/e2e/storage/nfs_persistent_volume-disruptive.go +++ b/test/e2e/storage/nfs_persistent_volume-disruptive.go @@ -75,7 +75,7 @@ func checkForControllerManagerHealthy(ctx context.Context, duration time.Duratio return nil } -var _ = utils.SIGDescribe("NFSPersistentVolumes", framework.WithDisruptive(), "[Flaky]", func() { +var _ = utils.SIGDescribe("NFSPersistentVolumes", framework.WithDisruptive(), framework.WithFlaky(), func() { f := framework.NewDefaultFramework("disruptive-pv") f.NamespacePodSecurityLevel = admissionapi.LevelPrivileged diff --git a/test/e2e/storage/persistent_volumes-local.go b/test/e2e/storage/persistent_volumes-local.go index 130afcb776b..91cc7cbd8d2 100644 --- a/test/e2e/storage/persistent_volumes-local.go +++ b/test/e2e/storage/persistent_volumes-local.go @@ -294,7 +294,7 @@ var _ = utils.SIGDescribe("PersistentVolumes-local", func() { e2epod.DeletePodOrFail(ctx, config.client, config.ns, pod2.Name) }) - ginkgo.It("should set different fsGroup for second pod if first pod is deleted [Flaky]", func(ctx context.Context) { + f.It("should set different fsGroup for second pod if first pod is deleted", f.WithFlaky(), func(ctx context.Context) { // TODO: Disabled temporarily, remove [Flaky] tag after #73168 is fixed. fsGroup1, fsGroup2 := int64(1234), int64(4321) ginkgo.By("Create first pod and check fsGroup is set")