From de015167a9c3a54d554fb05a338c685932e5dd90 Mon Sep 17 00:00:00 2001 From: juanvallejo Date: Wed, 30 Jan 2019 15:10:19 -0500 Subject: [PATCH] make missing-directory errors non fatal --- pkg/kubectl/cmd/plugin/BUILD | 1 + pkg/kubectl/cmd/plugin/plugin.go | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/pkg/kubectl/cmd/plugin/BUILD b/pkg/kubectl/cmd/plugin/BUILD index 5d9b2cd2b1c..6541bc9fcb9 100644 --- a/pkg/kubectl/cmd/plugin/BUILD +++ b/pkg/kubectl/cmd/plugin/BUILD @@ -11,6 +11,7 @@ go_library( "//pkg/kubectl/util/templates:go_default_library", "//staging/src/k8s.io/cli-runtime/pkg/genericclioptions:go_default_library", "//vendor/github.com/spf13/cobra:go_default_library", + "//vendor/k8s.io/klog:go_default_library", ], ) diff --git a/pkg/kubectl/cmd/plugin/plugin.go b/pkg/kubectl/cmd/plugin/plugin.go index d7df928098d..b7aba9d0713 100644 --- a/pkg/kubectl/cmd/plugin/plugin.go +++ b/pkg/kubectl/cmd/plugin/plugin.go @@ -28,6 +28,7 @@ import ( "github.com/spf13/cobra" "k8s.io/cli-runtime/pkg/genericclioptions" + "k8s.io/klog" cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" "k8s.io/kubernetes/pkg/kubectl/util/i18n" "k8s.io/kubernetes/pkg/kubectl/util/templates" @@ -117,6 +118,11 @@ func (o *PluginListOptions) Run() error { for _, dir := range uniquePathsList(o.PluginPaths) { files, err := ioutil.ReadDir(dir) if err != nil { + if _, ok := err.(*os.PathError); ok && strings.Contains(err.Error(), "no such file") { + klog.V(3).Infof("unable to find directory %q in your PATH. Skipping...", dir) + continue + } + pluginErrors = append(pluginErrors, fmt.Errorf("error: unable to read directory %q in your PATH: %v", dir, err)) continue }