mirror of
https://github.com/k3s-io/kubernetes.git
synced 2026-01-04 15:05:20 +00:00
add/update tests
Move negative check for testing "not patched" output to test-cmd-util.sh as exiting with code 1 was causing patch_test.go to fail when the error was expected as part of the test.
This commit is contained in:
@@ -38,7 +38,14 @@ func TestPatchObject(t *testing.T) {
|
||||
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
||||
switch p, m := req.URL.Path, req.Method; {
|
||||
case p == "/namespaces/test/services/frontend" && (m == "PATCH" || m == "GET"):
|
||||
return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(codec, &svc.Items[0])}, nil
|
||||
obj := svc.Items[0]
|
||||
|
||||
// ensure patched object reflects successful
|
||||
// patch edits from the client
|
||||
if m == "PATCH" {
|
||||
obj.Spec.Type = "NodePort"
|
||||
}
|
||||
return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(codec, &obj)}, nil
|
||||
default:
|
||||
t.Fatalf("unexpected request: %#v\n%#v", req.URL, req)
|
||||
return nil, nil
|
||||
@@ -116,18 +123,6 @@ func TestPatchNoop(t *testing.T) {
|
||||
}
|
||||
tf.Namespace = "test"
|
||||
|
||||
// No-op
|
||||
{
|
||||
buf := bytes.NewBuffer([]byte{})
|
||||
cmd := NewCmdPatch(f, buf)
|
||||
cmd.Flags().Set("namespace", "test")
|
||||
cmd.Flags().Set("patch", `{}`)
|
||||
cmd.Run(cmd, []string{"services", "frontend"})
|
||||
if buf.String() != "service \"baz\" not patched\n" {
|
||||
t.Errorf("unexpected output: %s", buf.String())
|
||||
}
|
||||
}
|
||||
|
||||
// Patched
|
||||
{
|
||||
patchObject = patchObject.DeepCopy()
|
||||
|
||||
Reference in New Issue
Block a user