From de41fd396087cd6b92c411efc592628422080253 Mon Sep 17 00:00:00 2001 From: Huamin Chen Date: Thu, 8 Oct 2015 13:50:41 -0400 Subject: [PATCH] rbd: no more remount. remount was originally needed to ensure rw/ro is set correctly. There is no such need since mount is using exec interface Signed-off-by: Huamin Chen --- pkg/volume/rbd/rbd.go | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/pkg/volume/rbd/rbd.go b/pkg/volume/rbd/rbd.go index 431f920da76..7a29ed3578a 100644 --- a/pkg/volume/rbd/rbd.go +++ b/pkg/volume/rbd/rbd.go @@ -201,18 +201,8 @@ func (b *rbdBuilder) SetUpAt(dir string) error { err := diskSetUp(b.manager, *b, dir, b.mounter) if err != nil { glog.Errorf("rbd: failed to setup") - return err } - globalPDPath := b.manager.MakeGlobalPDName(*b.rbd) - // make mountpoint rw/ro work as expected - //FIXME revisit pkg/util/mount and ensure rw/ro is implemented as expected - mode := "rw" - if b.ReadOnly { - mode = "ro" - } - b.plugin.execCommand("mount", []string{"-o", "remount," + mode, globalPDPath, dir}) - - return nil + return err } type rbdCleaner struct {