From de79209970303d13c73c175d7369e30c1f4f8550 Mon Sep 17 00:00:00 2001 From: Vishnu Kannan Date: Thu, 9 Apr 2015 15:38:36 -0700 Subject: [PATCH] Adding events API to cadvisor interface. --- pkg/kubelet/cadvisor/cadvisor_fake.go | 5 +++++ pkg/kubelet/cadvisor/cadvisor_linux.go | 5 +++++ pkg/kubelet/cadvisor/cadvisor_mock.go | 6 ++++++ pkg/kubelet/cadvisor/cadvisor_unsupported.go | 5 +++++ pkg/kubelet/cadvisor/types.go | 4 ++++ 5 files changed, 25 insertions(+) diff --git a/pkg/kubelet/cadvisor/cadvisor_fake.go b/pkg/kubelet/cadvisor/cadvisor_fake.go index 908f0708bb9..d43645f2f4e 100644 --- a/pkg/kubelet/cadvisor/cadvisor_fake.go +++ b/pkg/kubelet/cadvisor/cadvisor_fake.go @@ -17,6 +17,7 @@ limitations under the License. package cadvisor import ( + "github.com/google/cadvisor/events" cadvisorApi "github.com/google/cadvisor/info/v1" cadvisorApiV2 "github.com/google/cadvisor/info/v2" ) @@ -46,3 +47,7 @@ func (c *Fake) VersionInfo() (*cadvisorApi.VersionInfo, error) { func (c *Fake) DockerImagesFsInfo() (cadvisorApiV2.FsInfo, error) { return cadvisorApiV2.FsInfo{}, nil } + +func (c *Fake) GetPastEvents(request *events.Request) ([]*cadvisorApi.Event, error) { + return []*cadvisorApi.Event{}, nil +} diff --git a/pkg/kubelet/cadvisor/cadvisor_linux.go b/pkg/kubelet/cadvisor/cadvisor_linux.go index 631337eb428..6a75201c794 100644 --- a/pkg/kubelet/cadvisor/cadvisor_linux.go +++ b/pkg/kubelet/cadvisor/cadvisor_linux.go @@ -25,6 +25,7 @@ import ( "github.com/GoogleCloudPlatform/kubernetes/pkg/util" "github.com/golang/glog" + "github.com/google/cadvisor/events" cadvisorFs "github.com/google/cadvisor/fs" cadvisorHttp "github.com/google/cadvisor/http" cadvisorApi "github.com/google/cadvisor/info/v1" @@ -132,3 +133,7 @@ func (self *cadvisorClient) DockerImagesFsInfo() (cadvisorApiV2.FsInfo, error) { return res[0], nil } + +func (self *cadvisorClient) GetPastEvents(request *events.Request) ([]*cadvisorApi.Event, error) { + return self.GetPastEvents(request) +} diff --git a/pkg/kubelet/cadvisor/cadvisor_mock.go b/pkg/kubelet/cadvisor/cadvisor_mock.go index 9eeb7b4c071..b1aa1cfd2df 100644 --- a/pkg/kubelet/cadvisor/cadvisor_mock.go +++ b/pkg/kubelet/cadvisor/cadvisor_mock.go @@ -17,6 +17,7 @@ limitations under the License. package cadvisor import ( + "github.com/google/cadvisor/events" cadvisorApi "github.com/google/cadvisor/info/v1" cadvisorApiV2 "github.com/google/cadvisor/info/v2" "github.com/stretchr/testify/mock" @@ -55,3 +56,8 @@ func (c *Mock) DockerImagesFsInfo() (cadvisorApiV2.FsInfo, error) { args := c.Called() return args.Get(0).(cadvisorApiV2.FsInfo), args.Error(1) } + +func (c *Mock) GetPastEvents(request *events.Request) ([]*cadvisorApi.Event, error) { + args := c.Called() + return args.Get(0).([]*cadvisorApi.Event), args.Error(1) +} diff --git a/pkg/kubelet/cadvisor/cadvisor_unsupported.go b/pkg/kubelet/cadvisor/cadvisor_unsupported.go index 2d9b13eb65a..fc4cf575fed 100644 --- a/pkg/kubelet/cadvisor/cadvisor_unsupported.go +++ b/pkg/kubelet/cadvisor/cadvisor_unsupported.go @@ -21,6 +21,7 @@ package cadvisor import ( "errors" + "github.com/google/cadvisor/events" cadvisorApi "github.com/google/cadvisor/info/v1" cadvisorApiV2 "github.com/google/cadvisor/info/v2" ) @@ -55,3 +56,7 @@ func (self *cadvisorUnsupported) VersionInfo() (*cadvisorApi.VersionInfo, error) func (self *cadvisorUnsupported) DockerImagesFsInfo() (cadvisorApiV2.FsInfo, error) { return cadvisorApiV2.FsInfo{}, unsupportedErr } + +func (self *cadvisorUnsupported) GetPastEvents(request *events.Request) ([]*cadvisorApi.Event, error) { + return cadvisorApi.Event{}, unsupportedErr +} diff --git a/pkg/kubelet/cadvisor/types.go b/pkg/kubelet/cadvisor/types.go index 6607c0f0e00..a82390c4a99 100644 --- a/pkg/kubelet/cadvisor/types.go +++ b/pkg/kubelet/cadvisor/types.go @@ -17,6 +17,7 @@ limitations under the License. package cadvisor import ( + "github.com/google/cadvisor/events" cadvisorApi "github.com/google/cadvisor/info/v1" cadvisorApiV2 "github.com/google/cadvisor/info/v2" ) @@ -31,4 +32,7 @@ type Interface interface { // Returns usage information about the filesystem holding Docker images. DockerImagesFsInfo() (cadvisorApiV2.FsInfo, error) + + // Get past events that have been detected and that fit the request. + GetPastEvents(request *events.Request) ([]*cadvisorApi.Event, error) }