From 83603f0358d2bf5031f0298fd8bf85c5c24c05a3 Mon Sep 17 00:00:00 2001 From: Malepati Bala Siva Sai Akhil Date: Sat, 5 Aug 2017 22:47:48 +0530 Subject: [PATCH 1/4] Fix typo in comment Fix typo in comment in garbagecollector --- pkg/controller/garbagecollector/rate_limiter_helper.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/garbagecollector/rate_limiter_helper.go b/pkg/controller/garbagecollector/rate_limiter_helper.go index 8d43d28be40..26d89389154 100644 --- a/pkg/controller/garbagecollector/rate_limiter_helper.go +++ b/pkg/controller/garbagecollector/rate_limiter_helper.go @@ -32,7 +32,7 @@ type RegisteredRateLimiter struct { rateLimiters map[schema.GroupVersion]*sync.Once } -// NewRegisteredRateLimiter returns a new RegisteredRateLimiater. +// NewRegisteredRateLimiter returns a new RegisteredRateLimiter. // TODO: NewRegisteredRateLimiter is not dynamic. We need to find a better way // when GC dynamically change the resources it monitors. func NewRegisteredRateLimiter(resources map[schema.GroupVersionResource]struct{}) *RegisteredRateLimiter { From ee82de565abfa3a242e5349237fda06445c4bf9f Mon Sep 17 00:00:00 2001 From: Malepati Bala Siva Sai Akhil Date: Sat, 5 Aug 2017 16:20:49 +0530 Subject: [PATCH 2/4] Fixed typo in comment in eviction_manager Fixed typo in comment in eviction_manager --- pkg/kubelet/eviction/eviction_manager.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/eviction/eviction_manager.go b/pkg/kubelet/eviction/eviction_manager.go index f4b19cd5441..5841afe7cdd 100644 --- a/pkg/kubelet/eviction/eviction_manager.go +++ b/pkg/kubelet/eviction/eviction_manager.go @@ -309,8 +309,8 @@ func (m *managerImpl) synchronize(diskInfoProvider DiskInfoProvider, podFunc Act m.lastObservations = observations m.Unlock() - // evict pods if there is a resource uage violation from local volume temporary storage - // If eviction happenes in localVolumeEviction function, skip the rest of eviction action + // evict pods if there is a resource usage violation from local volume temporary storage + // If eviction happens in localVolumeEviction function, skip the rest of eviction action if utilfeature.DefaultFeatureGate.Enabled(features.LocalStorageCapacityIsolation) { if evictedPods := m.localStorageEviction(activePods); len(evictedPods) > 0 { return evictedPods From 84844bb6d6591861f1a60417e9c1f56b349ba72d Mon Sep 17 00:00:00 2001 From: Malepati Bala Siva Sai Akhil Date: Sat, 5 Aug 2017 20:41:02 +0530 Subject: [PATCH 3/4] Fixed typo in rkt Fixed typo in rkt --- pkg/kubelet/rkt/rkt.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/rkt/rkt.go b/pkg/kubelet/rkt/rkt.go index fb42a5c6523..1d79761a670 100644 --- a/pkg/kubelet/rkt/rkt.go +++ b/pkg/kubelet/rkt/rkt.go @@ -847,7 +847,7 @@ func (r *Runtime) newAppcRuntimeApp(pod *v1.Pod, podIP string, c v1.Container, r return err } - // Create additional mount for termintation message path. + // Create additional mount for termination message path. mount, err := r.makeContainerLogMount(opts, &c) if err != nil { return err From 0c548ea4821a432d9793434d06e685fda464c917 Mon Sep 17 00:00:00 2001 From: Malepati Bala Siva Sai Akhil Date: Sat, 5 Aug 2017 21:35:32 +0530 Subject: [PATCH 4/4] Fix typo in variable of remote Fix typo in variable of remote_runtime.go --- pkg/kubelet/remote/remote_runtime.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/remote/remote_runtime.go b/pkg/kubelet/remote/remote_runtime.go index 647c564b7e3..250dbdb7b26 100644 --- a/pkg/kubelet/remote/remote_runtime.go +++ b/pkg/kubelet/remote/remote_runtime.go @@ -38,20 +38,20 @@ type RemoteRuntimeService struct { } // NewRemoteRuntimeService creates a new internalapi.RuntimeService. -func NewRemoteRuntimeService(endpoint string, connectionTimout time.Duration) (internalapi.RuntimeService, error) { +func NewRemoteRuntimeService(endpoint string, connectionTimeout time.Duration) (internalapi.RuntimeService, error) { glog.Infof("Connecting to runtime service %s", endpoint) addr, dailer, err := util.GetAddressAndDialer(endpoint) if err != nil { return nil, err } - conn, err := grpc.Dial(addr, grpc.WithInsecure(), grpc.WithTimeout(connectionTimout), grpc.WithDialer(dailer)) + conn, err := grpc.Dial(addr, grpc.WithInsecure(), grpc.WithTimeout(connectionTimeout), grpc.WithDialer(dailer)) if err != nil { glog.Errorf("Connect remote runtime %s failed: %v", addr, err) return nil, err } return &RemoteRuntimeService{ - timeout: connectionTimout, + timeout: connectionTimeout, runtimeClient: runtimeapi.NewRuntimeServiceClient(conn), }, nil }