From deb234c9d5c7bae526e8525a9226cd8e86e935b8 Mon Sep 17 00:00:00 2001 From: xigang Date: Tue, 31 Dec 2024 11:15:29 +0800 Subject: [PATCH] refactor: simplify boolean expressions in CRD handler Signed-off-by: xigang --- .../pkg/apiserver/customresource_handler.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go index 55d31fc8eda..7147066d43a 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go @@ -660,13 +660,13 @@ func (r *crdHandler) getOrCreateServingInfoFor(uid types.UID, name string) (*crd return nil, fmt.Errorf("failed converting CRD validation to internal version: %v", err) } s, err := structuralschema.NewStructural(internalValidation.OpenAPIV3Schema) - if crd.Spec.PreserveUnknownFields == false && err != nil { + if !crd.Spec.PreserveUnknownFields && err != nil { // This should never happen. If it does, it is a programming error. utilruntime.HandleError(fmt.Errorf("failed to convert schema to structural: %v", err)) return nil, fmt.Errorf("the server could not properly serve the CR schema") // validation should avoid this } - if crd.Spec.PreserveUnknownFields == false { + if !crd.Spec.PreserveUnknownFields { // we don't own s completely, e.g. defaults are not deep-copied. So better make a copy here. s = s.DeepCopy()