From df1e9eeeb8c6cbf0f38a2fda4cbdc28a53577fa0 Mon Sep 17 00:00:00 2001 From: Mark Rossetti Date: Wed, 12 Feb 2025 15:11:33 -0800 Subject: [PATCH] skipping InPlacePodVerticleScaling unit tests on Windows Signed-off-by: Mark Rossetti --- pkg/kubelet/kubelet_pods_test.go | 7 +++++++ pkg/kubelet/kubelet_test.go | 3 +++ 2 files changed, 10 insertions(+) diff --git a/pkg/kubelet/kubelet_pods_test.go b/pkg/kubelet/kubelet_pods_test.go index 4fdf947485b..10be41a77d7 100644 --- a/pkg/kubelet/kubelet_pods_test.go +++ b/pkg/kubelet/kubelet_pods_test.go @@ -24,6 +24,7 @@ import ( "os" "path/filepath" "reflect" + goruntime "runtime" "sort" "strings" "testing" @@ -3821,6 +3822,9 @@ func Test_generateAPIPodStatus(t *testing.T) { } func Test_generateAPIPodStatusForInPlaceVPAEnabled(t *testing.T) { + if goruntime.GOOS == "windows" { + t.Skip("InPlacePodVerticalScaling is not currently supported for Windows") + } featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true) testContainerName := "ctr0" testContainerID := kubecontainer.ContainerID{Type: "test", ID: testContainerName} @@ -4635,6 +4639,9 @@ func TestConvertToAPIContainerStatusesDataRace(t *testing.T) { } func TestConvertToAPIContainerStatusesForResources(t *testing.T) { + if goruntime.GOOS == "windows" { + t.Skip("InPlacePodVerticalScaling is not currently supported for Windows") + } featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true) nowTime := time.Now() diff --git a/pkg/kubelet/kubelet_test.go b/pkg/kubelet/kubelet_test.go index 16786d6c5b9..5d8b9d397d8 100644 --- a/pkg/kubelet/kubelet_test.go +++ b/pkg/kubelet/kubelet_test.go @@ -2583,6 +2583,9 @@ func TestPodResourceAllocationReset(t *testing.T) { } func TestHandlePodResourcesResize(t *testing.T) { + if goruntime.GOOS == "windows" { + t.Skip("InPlacePodVerticalScaling is not currently supported for Windows") + } featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.InPlacePodVerticalScaling, true) featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.SidecarContainers, true) testKubelet := newTestKubelet(t, false)