github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-21 01:26:28 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #127540 from mmorel-35/testifylint/error-is-as@k8s.io/apiserver

Browse Source 
fix: enable error-is-as rule from testifylint in module `k8s.io/apiserver`
This commit is contained in:
Kubernetes Prow Robot 2024-09-23 09:06:13 +01:00 committed by GitHub
commit df5787a57f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/apiserver/pkg/util/proxy/streamtunnel_test.go
View File

@ -19,7 +19,6 @@ package proxy
import ( import (
"bytes" "bytes"
"crypto/rand" "crypto/rand"
"errors"
"fmt" "fmt"
"io" "io"
"net" "net"
@ -304,7 +303,7 @@ func TestTunnelingResponseWriter_DelegateResponseWriter(t *testing.T) {
trw.hijacked = true trw.hijacked = true
_, err = trw.Write(expectedWrite) _, err = trw.Write(expectedWrite)
assert.Error(t, err, "Writing to ResponseWriter after Hijack() is an error") assert.Error(t, err, "Writing to ResponseWriter after Hijack() is an error")
assert.True(t, errors.Is(err, http.ErrHijacked), "Hijacked error returned if writing after hijacked") require.ErrorIs(t, err, http.ErrHijacked, "Hijacked error returned if writing after hijacked")
// Validate WriteHeader(). // Validate WriteHeader().
trw = &tunnelingResponseWriter{w: &mockResponseWriter{}} trw = &tunnelingResponseWriter{w: &mockResponseWriter{}}
expectedStatusCode := 201 expectedStatusCode := 201