From df58c042a8ae6b6a522b44d81e69614038ebbe56 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Sat, 7 Mar 2020 00:37:01 +0100 Subject: [PATCH] metaproxier logging for endpoints ipfamily The kube-proxy metaproxier implementations tries to get the IPFamily from the endpoints, but if the endpoints doesn't contains an IP address it logs a Warning. This causes that services without endpoints keep flooding the logs with warnings. We log this errors with a level of Verbosity of 4 instead of a Warning --- pkg/proxy/metaproxier/BUILD | 9 ++++++++- pkg/proxy/metaproxier/meta_proxier.go | 6 +++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/pkg/proxy/metaproxier/BUILD b/pkg/proxy/metaproxier/BUILD index 4f11238d4a8..cbe5ad577c0 100644 --- a/pkg/proxy/metaproxier/BUILD +++ b/pkg/proxy/metaproxier/BUILD @@ -1,6 +1,6 @@ package(default_visibility = ["//visibility:public"]) -load("@io_bazel_rules_go//go:def.bzl", "go_library") +load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") go_library( name = "go_default_library", @@ -28,3 +28,10 @@ filegroup( srcs = [":package-srcs"], tags = ["automanaged"], ) + +go_test( + name = "go_default_test", + srcs = ["meta_proxier_test.go"], + embed = [":go_default_library"], + deps = ["//staging/src/k8s.io/api/core/v1:go_default_library"], +) diff --git a/pkg/proxy/metaproxier/meta_proxier.go b/pkg/proxy/metaproxier/meta_proxier.go index 9bfe44275d7..21cae0d9947 100644 --- a/pkg/proxy/metaproxier/meta_proxier.go +++ b/pkg/proxy/metaproxier/meta_proxier.go @@ -103,7 +103,7 @@ func (proxier *metaProxier) OnServiceSynced() { func (proxier *metaProxier) OnEndpointsAdd(endpoints *v1.Endpoints) { ipFamily, err := endpointsIPFamily(endpoints) if err != nil { - klog.Warningf("failed to add endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err) + klog.V(4).Infof("failed to add endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err) return } if *ipFamily == v1.IPv4Protocol { @@ -118,7 +118,7 @@ func (proxier *metaProxier) OnEndpointsAdd(endpoints *v1.Endpoints) { func (proxier *metaProxier) OnEndpointsUpdate(oldEndpoints, endpoints *v1.Endpoints) { ipFamily, err := endpointsIPFamily(endpoints) if err != nil { - klog.Warningf("failed to update endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err) + klog.V(4).Infof("failed to update endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err) return } @@ -134,7 +134,7 @@ func (proxier *metaProxier) OnEndpointsUpdate(oldEndpoints, endpoints *v1.Endpoi func (proxier *metaProxier) OnEndpointsDelete(endpoints *v1.Endpoints) { ipFamily, err := endpointsIPFamily(endpoints) if err != nil { - klog.Warningf("failed to delete endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err) + klog.V(4).Infof("failed to delete endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err) return }