From e0288342ef35ba30404877f9a748505807edc94e Mon Sep 17 00:00:00 2001 From: Michail Kargakis Date: Sat, 25 Feb 2017 12:49:59 +0100 Subject: [PATCH] Fix availableReplicas validation --- pkg/api/validation/validation.go | 4 ++-- pkg/apis/extensions/validation/validation.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/api/validation/validation.go b/pkg/api/validation/validation.go index 01474a2e80f..c268741360d 100644 --- a/pkg/api/validation/validation.go +++ b/pkg/api/validation/validation.go @@ -2736,8 +2736,8 @@ func ValidateReplicationControllerStatusUpdate(controller, oldController *api.Re if controller.Status.AvailableReplicas > controller.Status.Replicas { allErrs = append(allErrs, field.Invalid(statusPath.Child("availableReplicas"), controller.Status.AvailableReplicas, msg)) } - if controller.Status.ReadyReplicas > controller.Status.AvailableReplicas { - allErrs = append(allErrs, field.Invalid(statusPath.Child("readyReplicas"), controller.Status.ReadyReplicas, "cannot be greater than availableReplicas")) + if controller.Status.AvailableReplicas > controller.Status.ReadyReplicas { + allErrs = append(allErrs, field.Invalid(statusPath.Child("availableReplicas"), controller.Status.AvailableReplicas, "cannot be greater than readyReplicas")) } return allErrs } diff --git a/pkg/apis/extensions/validation/validation.go b/pkg/apis/extensions/validation/validation.go index 165a55a8db0..55b1aefda3a 100644 --- a/pkg/apis/extensions/validation/validation.go +++ b/pkg/apis/extensions/validation/validation.go @@ -292,8 +292,8 @@ func ValidateDeploymentStatus(status *extensions.DeploymentStatus, fldPath *fiel if status.AvailableReplicas > status.Replicas { allErrs = append(allErrs, field.Invalid(fldPath.Child("availableReplicas"), status.AvailableReplicas, msg)) } - if status.ReadyReplicas > status.AvailableReplicas { - allErrs = append(allErrs, field.Invalid(fldPath.Child("readyReplicas"), status.ReadyReplicas, "cannot be greater than availableReplicas")) + if status.AvailableReplicas > status.ReadyReplicas { + allErrs = append(allErrs, field.Invalid(fldPath.Child("availableReplicas"), status.AvailableReplicas, "cannot be greater than readyReplicas")) } return allErrs } @@ -528,8 +528,8 @@ func ValidateReplicaSetStatusUpdate(rs, oldRs *extensions.ReplicaSet) field.Erro if rs.Status.AvailableReplicas > rs.Status.Replicas { allErrs = append(allErrs, field.Invalid(fldPath.Child("availableReplicas"), rs.Status.AvailableReplicas, msg)) } - if rs.Status.ReadyReplicas > rs.Status.AvailableReplicas { - allErrs = append(allErrs, field.Invalid(fldPath.Child("readyReplicas"), rs.Status.ReadyReplicas, "cannot be greater than availableReplicas")) + if rs.Status.AvailableReplicas > rs.Status.ReadyReplicas { + allErrs = append(allErrs, field.Invalid(fldPath.Child("availableReplicas"), rs.Status.AvailableReplicas, "cannot be greater than readyReplicas")) } return allErrs }