From c13eb07cdf691b349368eb3c6bc6ee7d83c6e322 Mon Sep 17 00:00:00 2001 From: Michelle Au Date: Mon, 5 Nov 2018 10:57:37 -0800 Subject: [PATCH 1/2] Fix csi rbac in e2e manifests --- .../testing-manifests/storage-csi/external-attacher/rbac.yaml | 1 + .../testing-manifests/storage-csi/external-provisioner/rbac.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/test/e2e/testing-manifests/storage-csi/external-attacher/rbac.yaml b/test/e2e/testing-manifests/storage-csi/external-attacher/rbac.yaml index 707f73a2de7..18f1eff454f 100644 --- a/test/e2e/testing-manifests/storage-csi/external-attacher/rbac.yaml +++ b/test/e2e/testing-manifests/storage-csi/external-attacher/rbac.yaml @@ -79,3 +79,4 @@ subjects: roleRef: kind: Role name: external-attacher-cfg + apiGroup: rbac.authorization.k8s.io diff --git a/test/e2e/testing-manifests/storage-csi/external-provisioner/rbac.yaml b/test/e2e/testing-manifests/storage-csi/external-provisioner/rbac.yaml index 5d46d34bdc8..65bd2e42e97 100644 --- a/test/e2e/testing-manifests/storage-csi/external-provisioner/rbac.yaml +++ b/test/e2e/testing-manifests/storage-csi/external-provisioner/rbac.yaml @@ -87,3 +87,4 @@ subjects: roleRef: kind: Role name: external-provisioner-cfg + apiGroup: rbac.authorization.k8s.io From 75459fc3de28b4f05e27dd4e231c305a9f4bcf40 Mon Sep 17 00:00:00 2001 From: Michelle Au Date: Tue, 6 Nov 2018 10:39:36 -0800 Subject: [PATCH 2/2] remove subpath readonly test for new directories --- test/e2e/storage/testsuites/subpath.go | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/e2e/storage/testsuites/subpath.go b/test/e2e/storage/testsuites/subpath.go index b2ccfa29a75..2b04f14d33d 100644 --- a/test/e2e/storage/testsuites/subpath.go +++ b/test/e2e/storage/testsuites/subpath.go @@ -360,20 +360,6 @@ func testSubPath(input *subPathTestInput) { testReadFile(input.f, input.filePathInSubpath, input.pod, 0) }) - It("should fail for new directories when readOnly specified in the volumeSource [Slow]", func() { - if input.roVol == nil { - framework.Skipf("Volume type %v doesn't support readOnly source", input.volType) - } - - // Format the volume while it's writable - formatVolume(input.f, input.formatPod) - - // Set volume source to read only - input.pod.Spec.Volumes[0].VolumeSource = *input.roVol - // Pod should fail - testPodFailSubpathError(input.f, input.pod, "") - }) - // TODO: add a test case for the same disk with two partitions }