From e0784f2e00e1aa7f5a89309b1220982354fe9597 Mon Sep 17 00:00:00 2001 From: Wojciech Tyczynski Date: Fri, 20 Jan 2017 11:31:29 +0100 Subject: [PATCH] Propage secret volumes in secret manager --- pkg/kubelet/secret/secret_manager.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/secret/secret_manager.go b/pkg/kubelet/secret/secret_manager.go index eb9f8dec3c5..1ca703c0405 100644 --- a/pkg/kubelet/secret/secret_manager.go +++ b/pkg/kubelet/secret/secret_manager.go @@ -212,8 +212,6 @@ func (c *cachingSecretManager) GetSecret(namespace, name string) (*v1.Secret, er return c.secretStore.Get(namespace, name) } -// TODO: Before we will use secretManager in other places (e.g. for secret volumes) -// we should update this function to also get secrets from those places. func getSecretNames(pod *v1.Pod) sets.String { result := sets.NewString() for _, reference := range pod.Spec.ImagePullSecrets { @@ -226,6 +224,11 @@ func getSecretNames(pod *v1.Pod) sets.String { } } } + for i := range pod.Spec.Volumes { + if source := pod.Spec.Volumes[i].Secret; source != nil { + result.Insert(source.SecretName) + } + } return result }