From cd5415f0ab41e0d48cc22e918a77d7193cdfe013 Mon Sep 17 00:00:00 2001
From: yanghaichao12 <yang.haichao@zte.com.cn>
Date: Thu, 10 Jan 2019 10:40:06 -0500
Subject: [PATCH] add a test case for HostnameOverride

modify
---
 cmd/kube-proxy/app/server_test.go | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/cmd/kube-proxy/app/server_test.go b/cmd/kube-proxy/app/server_test.go
index b45066f86f4..b3b0f410ab8 100644
--- a/cmd/kube-proxy/app/server_test.go
+++ b/cmd/kube-proxy/app/server_test.go
@@ -381,16 +381,24 @@ func TestProcessHostnameOverrideFlag(t *testing.T) {
 		name                 string
 		hostnameOverrideFlag string
 		expectedHostname     string
+		expectError          bool
 	}{
 		{
 			name:                 "Hostname from config file",
 			hostnameOverrideFlag: "",
 			expectedHostname:     "foo",
+			expectError:          false,
 		},
 		{
 			name:                 "Hostname from flag",
 			hostnameOverrideFlag: "  bar ",
 			expectedHostname:     "bar",
+			expectError:          false,
+		},
+		{
+			name:                 "Hostname is space",
+			hostnameOverrideFlag: "   ",
+			expectError:          true,
 		},
 	}
 	for _, tc := range testCases {
@@ -403,9 +411,15 @@ func TestProcessHostnameOverrideFlag(t *testing.T) {
 			options.hostnameOverride = tc.hostnameOverrideFlag
 
 			err := options.processHostnameOverrideFlag()
-			assert.NoError(t, err, "unexpected error %v", err)
-			if tc.expectedHostname != options.config.HostnameOverride {
-				t.Fatalf("expected hostname: %s, but got: %s", tc.expectedHostname, options.config.HostnameOverride)
+			if tc.expectError {
+				if err == nil {
+					t.Fatalf("should error for this case %s", tc.name)
+				}
+			} else {
+				assert.NoError(t, err, "unexpected error %v", err)
+				if tc.expectedHostname != options.config.HostnameOverride {
+					t.Fatalf("expected hostname: %s, but got: %s", tc.expectedHostname, options.config.HostnameOverride)
+				}
 			}
 		})
 	}