From e0caf0b46f061c3fafa10aef83592fe300f2bf52 Mon Sep 17 00:00:00 2001 From: Abhishek Raut Date: Wed, 15 Jul 2020 18:58:25 -0700 Subject: [PATCH] Fix NetworkPolicy describe for egress-all policies NetworkPolicy egress-all `kubectl describe` output should refer to the term "destination" as opposed to "source" for describing policies which do not restrict traffic based on the destination. --- staging/src/k8s.io/kubectl/pkg/describe/describe.go | 2 +- staging/src/k8s.io/kubectl/pkg/describe/describe_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/describe/describe.go b/staging/src/k8s.io/kubectl/pkg/describe/describe.go index 24e70e2ae75..cfe9e8804ff 100644 --- a/staging/src/k8s.io/kubectl/pkg/describe/describe.go +++ b/staging/src/k8s.io/kubectl/pkg/describe/describe.go @@ -4157,7 +4157,7 @@ func printNetworkPolicySpecEgressTo(npers []networkingv1.NetworkPolicyEgressRule } } if len(nper.To) == 0 { - w.Write(LEVEL_0, "%s%s\n", initialIndent, "To: (traffic not restricted by source)") + w.Write(LEVEL_0, "%s%s\n", initialIndent, "To: (traffic not restricted by destination)") } else { for _, to := range nper.To { w.Write(LEVEL_0, "%s%s\n", initialIndent, "To:") diff --git a/staging/src/k8s.io/kubectl/pkg/describe/describe_test.go b/staging/src/k8s.io/kubectl/pkg/describe/describe_test.go index 6536c76189a..d5e754542c1 100644 --- a/staging/src/k8s.io/kubectl/pkg/describe/describe_test.go +++ b/staging/src/k8s.io/kubectl/pkg/describe/describe_test.go @@ -3480,7 +3480,7 @@ Spec: Except: 192.168.3.0/24, 192.168.4.0/24 ---------- To Port: (traffic allowed to all ports) - To: (traffic not restricted by source) + To: (traffic not restricted by destination) Policy Types: Ingress, Egress `