github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-18 08:09:58 +00:00
Code Issues Projects Releases Wiki Activity

Add test for compatible version

Browse Source
This commit is contained in:
Cici Huang 2025-01-13 19:11:32 +00:00
parent 8a5cf7b66f
commit e179f0e364
1 changed files with 53 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
staging/src/k8s.io/apiserver/pkg/admission/plugin/cel/condition_test.go
View File

@ -184,6 +184,7 @@ func TestCondition(t *testing.T) {
v130 := version.MajorMinor(1, 30)
v131 := version.MajorMinor(1, 31)
v127 := version.MajorMinor(1, 27)
var nilUnstructured *unstructured.Unstructured
cases := []struct {
@ -200,6 +201,7 @@ func TestCondition(t *testing.T) {
enableSelectors bool
compatibilityVersion *version.Version
envType environment.Type
}{
{
name: "valid syntax for object",
@ -867,6 +869,52 @@ func TestCondition(t *testing.T) {
hasParamKind: false,
namespaceObject: nsObject,
},
{
name: "cel lib not recognized in version earlier than introduced version",
validations: []ExpressionAccessor{
&testCondition{
Expression: "isQuantity(\"20M\")",
},
},
attributes: newValidAttribute(&podObject, false),
results: []EvaluationResult{
{
Error: fmt.Errorf("isQuantity"),
},
},
compatibilityVersion: v127,
},
{
name: "cel lib recognized in version later than introduced version",
validations: []ExpressionAccessor{
&testCondition{
Expression: "isQuantity(\"20M\")",
},
},
results: []EvaluationResult{
{
EvalResult: celtypes.True,
},
},
attributes: newValidAttribute(&podObject, false),
compatibilityVersion: v130,
},
{
name: "cel lib always recognized in stored expression",
validations: []ExpressionAccessor{
&testCondition{
Expression: "isQuantity(\"20M\")",
},
},
attributes: newValidAttribute(&podObject, false),
results: []EvaluationResult{
{
EvalResult: celtypes.True,
},
},
envType: environment.StoredExpressions,
compatibilityVersion: version.MajorMinor(1, 2),
},
}
for _, tc := range cases {
@ -891,7 +939,11 @@ func TestCondition(t *testing.T) {
t.Fatal(err)
}
c := NewConditionCompiler(env)
f := c.CompileCondition(tc.validations, OptionalVariableDeclarations{HasParams: tc.hasParamKind, HasAuthorizer: tc.authorizer != nil, StrictCost: tc.strictCost}, environment.NewExpressions)
envType := tc.envType
if envType == "" {
envType = environment.NewExpressions
}
f := c.CompileCondition(tc.validations, OptionalVariableDeclarations{HasParams: tc.hasParamKind, HasAuthorizer: tc.authorizer != nil, StrictCost: tc.strictCost}, envType)
if f == nil {
t.Fatalf("unexpected nil validator")
}