From 6c6865af280d42b47d95a2bc792e965a4458a3f7 Mon Sep 17 00:00:00 2001 From: Swati Sehgal Date: Thu, 13 Oct 2022 11:33:24 +0100 Subject: [PATCH] node: e2e: memorymgr: Fix test failure The change made in https://github.com/kubernetes/kubernetes/pull/112644 resulted in an update to the rejection message. In the memory manager node e2e test, we still checked against the old expected error message giving the impression that the pod succeeded to run even though it failed as expected mainly because the check wasn't performed correctly. In this patch, we update to the correct rejection message to make sure that the memory manager is no longer failing. NOTE: This test is supposed to run on multi NUMA systems and if the underlying node does not have multi NUMA nodes, the test is skipped which is what happens in upstream test infrastructure as it is mainly composed of single NUMA nodes. Because of this, this test failure wasn't evident via testgrid. Signed-off-by: Swati Sehgal --- test/e2e_node/memory_manager_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e_node/memory_manager_test.go b/test/e2e_node/memory_manager_test.go index ea4b9d3955b..9ec4bcad318 100644 --- a/test/e2e_node/memory_manager_test.go +++ b/test/e2e_node/memory_manager_test.go @@ -621,7 +621,7 @@ var _ = SIGDescribe("Memory Manager [Disruptive] [Serial] [Feature:MemoryManager return false } - if !strings.Contains(tmpPod.Status.Message, "Pod Allocate failed due to [memorymanager]") { + if !strings.Contains(tmpPod.Status.Message, "Allocate failed due to [memorymanager]") { return false }