From e187368242b8b4179c14a6b1144b904063992993 Mon Sep 17 00:00:00 2001 From: ithrael Date: Wed, 30 Aug 2023 10:39:58 +0800 Subject: [PATCH] fix(test): fix TestGetPodResourcesV1 comparison logic in tests --- pkg/kubelet/apis/podresources/server_v1_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/apis/podresources/server_v1_test.go b/pkg/kubelet/apis/podresources/server_v1_test.go index b05f6e125f0..0852d7040d0 100644 --- a/pkg/kubelet/apis/podresources/server_v1_test.go +++ b/pkg/kubelet/apis/podresources/server_v1_test.go @@ -705,13 +705,18 @@ func TestGetPodResourcesV1(t *testing.T) { server := NewV1PodResourcesServer(providers) podReq := &podresourcesapi.GetPodResourcesRequest{PodName: podName, PodNamespace: podNamespace} resp, err := server.Get(context.TODO(), podReq) + if err != nil { if err.Error() != tc.err.Error() { t.Errorf("want exit = %v, got %v", tc.err, err) } } else { - if !equalGetResponse(tc.expectedResponse, resp) { - t.Errorf("want resp = %s, got %s", tc.expectedResponse.String(), resp.String()) + if err != tc.err { + t.Errorf("want exit = %v, got %v", tc.err, err) + } else { + if !equalGetResponse(tc.expectedResponse, resp) { + t.Errorf("want resp = %s, got %s", tc.expectedResponse.String(), resp.String()) + } } } })