From e1ba3da16c9bebccb3902952d56b59f2e2dbb900 Mon Sep 17 00:00:00 2001 From: Shyam Jeedigunta Date: Fri, 15 Sep 2017 15:55:58 +0200 Subject: [PATCH] Increase sliding window to 5hr for request_latencies metric --- .../src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go index ea28f66bc8d..90eaed114c2 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go @@ -56,8 +56,9 @@ var ( prometheus.SummaryOpts{ Name: "apiserver_request_latencies_summary", Help: "Response latency summary in microseconds for each verb, resource and subresource.", - // Make the sliding window of 1h. - MaxAge: time.Hour, + // Make the sliding window of 5h. + // TODO: The value for this should be based on our SLI definition (medium term). + MaxAge: 5 * time.Hour, }, []string{"verb", "resource", "subresource", "scope"}, )