From e280ec0fa24e215655d3792360560db458146e42 Mon Sep 17 00:00:00 2001
From: "Dr. Stefan Schimanski" <stefan.schimanski@gmail.com>
Date: Mon, 10 Jun 2019 18:06:37 +0200
Subject: [PATCH] apiextensions: add items+additionalProperties test coverage
 for objectmeta.Validate

---
 .../schema/objectmeta/validation_test.go      | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/validation_test.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/validation_test.go
index 3ac225ff804..bed35140be1 100644
--- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/validation_test.go
+++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/validation_test.go
@@ -139,6 +139,20 @@ func TestValidate(t *testing.T) {
 			required("nested", "embedded", "apiVersion"),
 			required("nested", "embedded", "kind"),
 		}},
+		{name: "items", object: `
+{
+  "items": [{}]
+}`, errors: []validationMatch{
+			required("items[0]", "apiVersion"),
+			required("items[0]", "kind"),
+		}},
+		{name: "additionalProperties", object: `
+{
+  "additionalProperties": {"foo":{}}
+}`, errors: []validationMatch{
+			required("additionalProperties[foo]", "apiVersion"),
+			required("additionalProperties[foo]", "kind"),
+		}},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -151,6 +165,20 @@ func TestValidate(t *testing.T) {
 							"embedded": {Extensions: structuralschema.Extensions{XEmbeddedResource: true}},
 						},
 					},
+					"items": {
+						Items: &structuralschema.Structural{
+							Extensions: structuralschema.Extensions{XEmbeddedResource: true},
+						},
+					},
+					"additionalProperties": {
+						Generic: structuralschema.Generic{
+							AdditionalProperties: &structuralschema.StructuralOrBool{
+								Structural: &structuralschema.Structural{
+									Extensions: structuralschema.Extensions{XEmbeddedResource: true},
+								},
+							},
+						},
+					},
 				},
 			}