Merge pull request #77433 from cwdsuzhou/common_func_for_ad

Add common func for NewAttacher and NewDetacher
This commit is contained in:
Kubernetes Prow Robot 2019-05-07 09:51:56 -07:00 committed by GitHub
commit e332051416
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -550,17 +550,7 @@ var _ volume.AttachableVolumePlugin = &csiPlugin{}
var _ volume.DeviceMountableVolumePlugin = &csiPlugin{}
func (p *csiPlugin) NewAttacher() (volume.Attacher, error) {
k8s := p.host.GetKubeClient()
if k8s == nil {
klog.Error(log("unable to get kubernetes client from host"))
return nil, errors.New("unable to get Kubernetes client")
}
return &csiAttacher{
plugin: p,
k8s: k8s,
waitSleepTime: 1 * time.Second,
}, nil
return p.newAttacherDetacher()
}
func (p *csiPlugin) NewDeviceMounter() (volume.DeviceMounter, error) {
@ -568,17 +558,7 @@ func (p *csiPlugin) NewDeviceMounter() (volume.DeviceMounter, error) {
}
func (p *csiPlugin) NewDetacher() (volume.Detacher, error) {
k8s := p.host.GetKubeClient()
if k8s == nil {
klog.Error(log("unable to get kubernetes client from host"))
return nil, errors.New("unable to get Kubernetes client")
}
return &csiAttacher{
plugin: p,
k8s: k8s,
waitSleepTime: 1 * time.Second,
}, nil
return p.newAttacherDetacher()
}
func (p *csiPlugin) CanAttach(spec *volume.Spec) (bool, error) {
@ -837,6 +817,20 @@ func (p *csiPlugin) getPublishContext(client clientset.Interface, handle, driver
return attachment.Status.AttachmentMetadata, nil
}
func (p *csiPlugin) newAttacherDetacher() (*csiAttacher, error) {
k8s := p.host.GetKubeClient()
if k8s == nil {
klog.Error(log("unable to get kubernetes client from host"))
return nil, errors.New("unable to get Kubernetes client")
}
return &csiAttacher{
plugin: p,
k8s: k8s,
waitSleepTime: 1 * time.Second,
}, nil
}
func unregisterDriver(driverName string) error {
csiDrivers.Delete(driverName)