github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #32016 from Random-Liu/fix-node-problem-detector-test-flake

Browse Source 
Automatic merge from submit-queue

Node Problem Detector: Use the right waiting time for eventually in NPD node e2e

Fixes https://github.com/kubernetes/kubernetes/issues/29656.
The `Eventually` check changed in this PR is used to make sure NPD generating default node condition after it starts. Mostly it should happen very fast, but sometimes it may take some time.

In the test, we should use `pollTimeout`(`1m`) for eventually check which is long enough, but we used `pollConsistent`(`5s`) by mistake.

This PR changed the eventually check to use `pollTimeout`(`1m`).

Mark P1 to match the corresponding test flake.

/cc @krousey @pwittrock
This commit is contained in:
Kubernetes Submit Queue 2016-09-02 17:35:32 -07:00 committed by GitHub
commit e358b8e6e2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/e2e/node_problem_detector.go
View File

@ -202,7 +202,7 @@ var _ = framework.KubeDescribe("NodeProblemDetector", func() {
By("Make sure the default node condition is generated")
Eventually(func() error {
return verifyCondition(c.Nodes(), node.Name, condition, api.ConditionFalse, defaultReason, defaultMessage)
}, pollConsistent, pollInterval).Should(Succeed())
}, pollTimeout, pollInterval).Should(Succeed())
num := 3
By(fmt.Sprintf("Inject %d temporary errors", num))