github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 10:51:29 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #109925 from MikeSpreitzer/more-better-bench

Browse Source 
Simplify and extend the benchmarks of prometheusextension timing histograms
This commit is contained in:
Kubernetes Prow Robot 2022-05-10 05:18:08 -07:00 committed by GitHub
commit e38dba7a15
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 42 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
staging/src/k8s.io/component-base/metrics/prometheusextension/timing_histogram_test.go
View File

@ -202,8 +202,7 @@ func (ufc *unsyncFakeClock) SetTime(now time.Time) {
func BenchmarkTimingHistogramDirect(b *testing.B) {
b.StopTimer()
now := time.Now()
clk := &unsyncFakeClock{now: now}
hist, err := NewTestableTimingHistogram(clk.Now, TimingHistogramOpts{
hist, err := NewTestableTimingHistogram(func() time.Time { return now }, TimingHistogramOpts{
Namespace: "testns",
Subsystem: "testsubsys",
Name: "testhist",
@ -216,8 +215,48 @@ func BenchmarkTimingHistogramDirect(b *testing.B) {
var x int
b.StartTimer()
for i := 0; i < b.N; i++ {
clk.now = clk.now.Add(time.Duration(31-x) * time.Microsecond)
now = now.Add(time.Duration(31-x) * time.Microsecond)
hist.Set(float64(x))
x = (x + i) % 23
}
}
func BenchmarkTimingHistogramVecEltCached(b *testing.B) {
b.StopTimer()
now := time.Now()
vec := NewTestableTimingHistogramVec(func() time.Time { return now }, TimingHistogramOpts{
Namespace: "testns",
Subsystem: "testsubsys",
Name: "testhist",
Help: "Me",
Buckets: []float64{1, 2, 4, 8, 16},
},
"label1", "label2")
hist := vec.WithLabelValues("val1", "val2")
var x int
b.StartTimer()
for i := 0; i < b.N; i++ {
now = now.Add(time.Duration(31-x) * time.Microsecond)
hist.Set(float64(x))
x = (x + i) % 23
}
}
func BenchmarkTimingHistogramVecEltFetched(b *testing.B) {
b.StopTimer()
now := time.Now()
vec := NewTestableTimingHistogramVec(func() time.Time { return now }, TimingHistogramOpts{
Namespace: "testns",
Subsystem: "testsubsys",
Name: "testhist",
Help: "Me",
Buckets: []float64{1, 2, 4, 8, 16},
},
"label1", "label2")
var x int
b.StartTimer()
for i := 0; i < b.N; i++ {
now = now.Add(time.Duration(31-x) * time.Microsecond)
vec.WithLabelValues("val1", "val2").Set(float64(x))
x = (x + i) % 23
}
}