mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-29 14:37:00 +00:00
e2e: Provide more helpful error output for failing test
Tests should provide more verbose output when their core functionality fails; in this case we were only logging that the job count did not match but this is not sufficient for understanding a failure.
This commit is contained in:
parent
0c0408c790
commit
e3a9d6fd1a
@ -269,8 +269,11 @@ var _ = SIGDescribe("CronJob", func() {
|
||||
ginkgo.By("Ensuring a finished job exists by listing jobs explicitly")
|
||||
jobs, err := f.ClientSet.BatchV1().Jobs(f.Namespace.Name).List(metav1.ListOptions{})
|
||||
framework.ExpectNoError(err, "Failed to ensure a finished cronjob exists by listing jobs explicitly in namespace %s", f.Namespace.Name)
|
||||
_, finishedJobs := filterActiveJobs(jobs)
|
||||
framework.ExpectEqual(len(finishedJobs), 1)
|
||||
activeJobs, finishedJobs := filterActiveJobs(jobs)
|
||||
if len(finishedJobs) != 1 {
|
||||
framework.Logf("Expected one finished job in namespace %s; activeJobs=%v; finishedJobs=%v", f.Namespace.Name, activeJobs, finishedJobs)
|
||||
framework.ExpectEqual(len(finishedJobs), 1)
|
||||
}
|
||||
|
||||
// Job should get deleted when the next job finishes the next minute
|
||||
ginkgo.By("Ensuring this job and its pods does not exist anymore")
|
||||
|
Loading…
Reference in New Issue
Block a user