github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 12:07:47 +00:00
Code Issues Projects Releases Wiki Activity

fix HPA plain metric calculate

Browse Source 
fix inconsistency in plain metric replica calculator when usageRatio == 1.0, keep same with resource replicas
This commit is contained in:
zach593 2023-05-10 11:14:29 +08:00
parent 6aa68d6a8b
commit e3d5feb76c
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/podautoscaler/replica_calculator.go
View File

@ -214,7 +214,7 @@ func (c *ReplicaCalculator) calcPlainMetricReplicas(metrics metricsclient.PodMet
for podName := range missingPods {
metrics[podName] = metricsclient.PodMetric{Value: targetUsage}
}
} else {
} else if usageRatio > 1.0 {
// on a scale-up, treat missing pods as using 0% of the resource request
for podName := range missingPods {
metrics[podName] = metricsclient.PodMetric{Value: 0}

15
pkg/controller/podautoscaler/replica_calculator_test.go
View File

@ -1322,6 +1322,21 @@ func TestReplicaCalcEmptyCPURequest(t *testing.T) {
tc.runTest(t)
}
func TestPlainMetricReplicaCalcMissingMetricsNoChangeEq(t *testing.T) {
tc := replicaCalcTestCase{
currentReplicas: 5,
expectedReplicas: 5,
metric: &metricInfo{
name: "qps",
levels: []int64{20000, 19000, 21000},
targetUsage: 20000,
expectedUsage: 20000,
metricType: podMetric,
},
}
tc.runTest(t)
}
func TestReplicaCalcMissingMetricsNoChangeEq(t *testing.T) {
tc := replicaCalcTestCase{
currentReplicas: 2,