From e3e9de6010ebcc1024afd4db8bc67a03a51d30f2 Mon Sep 17 00:00:00 2001 From: Marek Grabowski Date: Mon, 18 Sep 2017 10:45:06 +0100 Subject: [PATCH] Fix panic in ControllerManager when GCE external loadbalancer healthcheck is nil --- pkg/cloudprovider/providers/gce/gce_loadbalancer_external.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/cloudprovider/providers/gce/gce_loadbalancer_external.go b/pkg/cloudprovider/providers/gce/gce_loadbalancer_external.go index c4f3beccb67..0d07647c7a0 100644 --- a/pkg/cloudprovider/providers/gce/gce_loadbalancer_external.go +++ b/pkg/cloudprovider/providers/gce/gce_loadbalancer_external.go @@ -514,8 +514,9 @@ func (gce *GCECloud) createTargetPool(svc *v1.Service, name, serviceName, ipAddr return err } var err error + hcRequestPath, hcPort := hc.RequestPath, hc.Port if hc, err = gce.ensureHttpHealthCheck(hc.Name, hc.RequestPath, int32(hc.Port)); err != nil || hc == nil { - return fmt.Errorf("Failed to ensure health check for %v port %d path %v: %v", name, hc.Port, hc.RequestPath, err) + return fmt.Errorf("Failed to ensure health check for %v port %d path %v: %v", name, hcPort, hcRequestPath, err) } hcLinks = append(hcLinks, hc.SelfLink) }