Merge pull request #123834 from alvaroaleman/emit-err

Nodelifecycle: Emit event when deletion failed
This commit is contained in:
Kubernetes Prow Robot 2024-04-18 01:04:03 -07:00 committed by GitHub
commit e43015ad42
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -42,7 +42,8 @@ import (
)
const (
deleteNodeEvent = "DeletingNode"
deleteNodeEvent = "DeletingNode"
deleteNodeFailedEvent = "DeletingNodeFailed"
)
var ShutdownTaint = &v1.Taint{
@ -175,6 +176,8 @@ func (c *CloudNodeLifecycleController) MonitorNodes(ctx context.Context) {
if err := c.kubeClient.CoreV1().Nodes().Delete(ctx, node.Name, metav1.DeleteOptions{}); err != nil {
klog.Errorf("unable to delete node %q: %v", node.Name, err)
c.recorder.Eventf(ref, v1.EventTypeWarning, deleteNodeFailedEvent,
"Failed deleting node %s: %v", node.Name, err)
}
} else {
// Node exists. We need to check this to get taint working in similar in all cloudproviders