github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-08 03:33:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #122170 from yanfeng1992/master-new

Browse Source 
add warning for duplicate port name definition
This commit is contained in:
Kubernetes Prow Robot 2024-12-12 02:56:26 +00:00 committed by GitHub
commit e43e68fdc3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 206 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/api/pod/warnings.go
View File

@ -320,6 +320,21 @@ func warningsForPodSpecAndMeta(fieldPath *field.Path, podSpec *api.PodSpec, meta
return true return true
}) })
// Accumulate port names of containers and sidecar containers
allPortsNames := map[string]*field.Path{}
pods.VisitContainersWithPath(podSpec, fieldPath.Child("spec"), func(c *api.Container, fldPath *field.Path) bool {
for i, port := range c.Ports {
if port.Name != "" {
if other, found := allPortsNames[port.Name]; found {
warnings = append(warnings, fmt.Sprintf("%s: duplicate port name %q with %s, services and probes that select ports by name will use %s", fldPath.Child("ports").Index(i), port.Name, other, other))
} else {
allPortsNames[port.Name] = fldPath.Child("ports").Index(i)
}
}
}
return true
})
// warn if the terminationGracePeriodSeconds is negative. // warn if the terminationGracePeriodSeconds is negative.
if podSpec.TerminationGracePeriodSeconds != nil && *podSpec.TerminationGracePeriodSeconds < 0 { if podSpec.TerminationGracePeriodSeconds != nil && *podSpec.TerminationGracePeriodSeconds < 0 {
warnings = append(warnings, fmt.Sprintf("%s: must be >= 0; negative values are invalid and will be treated as 1", fieldPath.Child("spec", "terminationGracePeriodSeconds"))) warnings = append(warnings, fmt.Sprintf("%s: must be >= 0; negative values are invalid and will be treated as 1", fieldPath.Child("spec", "terminationGracePeriodSeconds")))

191
pkg/api/pod/warnings_test.go
View File

@ -140,6 +140,7 @@ func BenchmarkWarnings(b *testing.B) {
} }
func TestWarnings(t *testing.T) { func TestWarnings(t *testing.T) {
containerRestartPolicyAlways := api.ContainerRestartPolicyAlways
resources := api.ResourceList{ resources := api.ResourceList{
api.ResourceCPU: resource.MustParse("100m"), api.ResourceCPU: resource.MustParse("100m"),
api.ResourceMemory: resource.MustParse("4m"), api.ResourceMemory: resource.MustParse("4m"),
@ -1520,6 +1521,196 @@ func TestWarnings(t *testing.T) {
`spec.containers[1].ports[1]: duplicate port definition with spec.containers[1].ports[0]`, `spec.containers[1].ports[1]: duplicate port definition with spec.containers[1].ports[0]`,
}, },
}, },
{
name: "create duplicate container ports name in two containers",
template: &api.PodTemplateSpec{Spec: api.PodSpec{
Containers: []api.Container{
{
Name: "foo1",
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
{
Name: "foo",
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolTCP, Name: "test"},
},
}},
}},
expected: []string{
`spec.containers[1].ports[0]: duplicate port name "test" with spec.containers[0].ports[0], services and probes that select ports by name will use spec.containers[0].ports[0]`,
},
},
{
name: "update duplicate container ports name in two containers",
template: &api.PodTemplateSpec{Spec: api.PodSpec{
Containers: []api.Container{
{
Name: "foo1",
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
{
Name: "foo",
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolUDP, Name: "test1"},
{ContainerPort: 8092, Protocol: api.ProtocolUDP, Name: "test"},
},
}},
}},
oldTemplate: &api.PodTemplateSpec{Spec: api.PodSpec{
Containers: []api.Container{
{
Name: "foo1",
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
{
Name: "foo",
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolUDP, Name: "test1"},
},
}},
}},
expected: []string{
`spec.containers[1].ports[1]: duplicate port name "test" with spec.containers[0].ports[0], services and probes that select ports by name will use spec.containers[0].ports[0]`,
},
},
{
name: "create duplicate container ports name in two sidecar containers",
template: &api.PodTemplateSpec{Spec: api.PodSpec{
InitContainers: []api.Container{
{
RestartPolicy: &containerRestartPolicyAlways,
Name: "foo1",
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
{
Name: "foo",
RestartPolicy: &containerRestartPolicyAlways,
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolTCP, Name: "test"},
},
}},
}},
expected: []string{
`spec.initContainers[1].ports[0]: duplicate port name "test" with spec.initContainers[0].ports[0], services and probes that select ports by name will use spec.initContainers[0].ports[0]`,
},
},
{
name: "update duplicate container ports name in two sidecar containers",
template: &api.PodTemplateSpec{Spec: api.PodSpec{
InitContainers: []api.Container{
{
Name: "foo1",
RestartPolicy: &containerRestartPolicyAlways,
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
{
Name: "foo",
RestartPolicy: &containerRestartPolicyAlways,
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolUDP, Name: "test1"},
{ContainerPort: 8091, Protocol: api.ProtocolUDP, Name: "test"},
},
}},
}},
oldTemplate: &api.PodTemplateSpec{Spec: api.PodSpec{
Containers: []api.Container{
{
Name: "foo1",
RestartPolicy: &containerRestartPolicyAlways,
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
{
Name: "foo",
RestartPolicy: &containerRestartPolicyAlways,
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolUDP, Name: "test1"},
},
}},
}},
expected: []string{
`spec.initContainers[1].ports[1]: duplicate port name "test" with spec.initContainers[0].ports[0], services and probes that select ports by name will use spec.initContainers[0].ports[0]`,
},
},
{
name: "create duplicate container ports name in containers and sidecar containers",
template: &api.PodTemplateSpec{Spec: api.PodSpec{
InitContainers: []api.Container{
{
RestartPolicy: &containerRestartPolicyAlways,
Name: "foo1",
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
},
Containers: []api.Container{
{
Name: "foo",
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolTCP, Name: "test"},
},
}},
}},
expected: []string{
`spec.containers[0].ports[0]: duplicate port name "test" with spec.initContainers[0].ports[0], services and probes that select ports by name will use spec.initContainers[0].ports[0]`,
},
},
{
name: "update duplicate container ports name in containers and sidecar containers",
template: &api.PodTemplateSpec{Spec: api.PodSpec{
InitContainers: []api.Container{
{
Name: "foo1",
RestartPolicy: &containerRestartPolicyAlways,
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
},
Containers: []api.Container{
{
Name: "foo",
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolUDP, Name: "test1"},
{ContainerPort: 8092, Protocol: api.ProtocolUDP, Name: "test"},
},
},
},
}},
oldTemplate: &api.PodTemplateSpec{Spec: api.PodSpec{
InitContainers: []api.Container{
{
Name: "foo1",
RestartPolicy: &containerRestartPolicyAlways,
Ports: []api.ContainerPort{
{ContainerPort: 80, Protocol: api.ProtocolUDP, Name: "test"},
},
},
},
Containers: []api.Container{
{
Name: "foo",
Ports: []api.ContainerPort{
{ContainerPort: 8090, Protocol: api.ProtocolUDP, Name: "test1"},
},
}},
}},
expected: []string{
`spec.containers[0].ports[1]: duplicate port name "test" with spec.initContainers[0].ports[0], services and probes that select ports by name will use spec.initContainers[0].ports[0]`,
},
},
} }
for _, tc := range testcases { for _, tc := range testcases {