github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 10:43:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #8921 from wojtek-t/update_instructions

Browse Source 
Update instructions on auto-generating conversions.
This commit is contained in:
Tim Hockin 2015-05-28 15:01:24 -07:00
commit e456e8d63e
2 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/devel/api_changes.md
View File

@ -254,6 +254,12 @@ regenerate auto-generated ones. To regenerate them:
$ hack/update-generated-conversions.sh $ hack/update-generated-conversions.sh
``` ```
If running the above script is impossible due to compile errors, the easiest
workaround is to comment out the code causing errors and let the script to
regenerate it. If the auto-generated conversion methods are not used by the
manually-written ones, it's fine to just remove the whole file and let the
generator to create it from scratch.
Unsurprisingly, adding manually written conversion also requires you to add tests to Unsurprisingly, adding manually written conversion also requires you to add tests to
`pkg/api/<version>/conversion_test.go`. `pkg/api/<version>/conversion_test.go`.

19
hack/update-generated-deep-copies.sh
View File

@ -18,6 +18,15 @@ set -o errexit
set -o nounset set -o nounset
set -o pipefail set -o pipefail
function result_file_name() {
local version=$1
if [ "${version}" == "api" ]; then
echo "pkg/api/deep_copy_generated.go"
else
echo "pkg/api/${version}/deep_copy_generated.go"
fi
}
function generate_version() { function generate_version() {
local version=$1 local version=$1
local TMPFILE="/tmp/deep_copy_generated.$(date +%s).go" local TMPFILE="/tmp/deep_copy_generated.$(date +%s).go"
@ -38,14 +47,14 @@ EOF
EOF EOF
gofmt -w -s $TMPFILE gofmt -w -s $TMPFILE
if [ "${version}" == "api" ]; then mv $TMPFILE `result_file_name ${version}`
mv $TMPFILE pkg/api/deep_copy_generated.go
else
mv $TMPFILE pkg/api/${version}/deep_copy_generated.go
fi
} }
VERSIONS="api v1beta3 v1" VERSIONS="api v1beta3 v1"
# To avoid compile errors, remove the currently existing files.
for ver in $VERSIONS; do
rm -f `result_file_name ${ver}`
done
for ver in $VERSIONS; do for ver in $VERSIONS; do
generate_version "${ver}" generate_version "${ver}"
done done