From c4bae5658f7d7bf6ac69cbf85b21415928a81cd1 Mon Sep 17 00:00:00 2001 From: aram price Date: Thu, 4 Mar 2021 11:18:28 -0800 Subject: [PATCH] Update build/README.md and build/root/Makefile * build/README.md includes info about KUBE_BASE_IMAGE_REGISTRY * build/root/Makefile contains the correct default value for KUBE_BASE_IMAGE_REGISTRY --- build/README.md | 2 +- build/root/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build/README.md b/build/README.md index dc23bdfc958..02f75e271ef 100644 --- a/build/README.md +++ b/build/README.md @@ -34,7 +34,7 @@ The following scripts are found in the [`build/`](.) directory. Note that all sc ## Basic Flow -The scripts directly under [`build/`](.) are used to build and test. They will ensure that the `kube-build` Docker image is built (based on [`build/build-image/Dockerfile`](build-image/Dockerfile) and after base image's `KUBE_BUILD_IMAGE_CROSS_TAG` from Dockerfile is replaced with one of those actual tags of the base image, like `v1.13.9-2`) and then execute the appropriate command in that container. These scripts will both ensure that the right data is cached from run to run for incremental builds and will copy the results back out of the container. +The scripts directly under [`build/`](.) are used to build and test. They will ensure that the `kube-build` Docker image is built (based on [`build/build-image/Dockerfile`](build-image/Dockerfile) and after base image's `KUBE_BUILD_IMAGE_CROSS_TAG` from Dockerfile is replaced with one of those actual tags of the base image, like `v1.13.9-2`) and then execute the appropriate command in that container. These scripts will both ensure that the right data is cached from run to run for incremental builds and will copy the results back out of the container. You can specify a different registry/name for `kube-cross` by setting `KUBE_BASE_IMAGE_REGISTRY` which defaults to `k8s.gcr.io/build-image`. The `kube-build` container image is built by first creating a "context" directory in `_output/images/build-image`. It is done there instead of at the root of the Kubernetes repo to minimize the amount of data we need to package up when building the image. diff --git a/build/root/Makefile b/build/root/Makefile index 43ce95f8f4d..5adf5181fb6 100644 --- a/build/root/Makefile +++ b/build/root/Makefile @@ -437,7 +437,7 @@ define RELEASE_SKIP_TESTS_HELP_INFO # KUBE_RELEASE_RUN_TESTS: Whether to run tests. Set to 'y' to run tests anyways. # KUBE_FASTBUILD: Whether to cross-compile for other architectures. Set to 'false' to do so. # KUBE_DOCKER_REGISTRY: Registry of released images, default to k8s.gcr.io -# KUBE_BASE_IMAGE_REGISTRY: Registry of base images for controlplane binaries, default to k8s.gcr.io +# KUBE_BASE_IMAGE_REGISTRY: Registry of base images for controlplane binaries, default to k8s.gcr.io/build-image # # Example: # make release-skip-tests