From 55e2906f79422905a4b14bf36c5f60631f5308d5 Mon Sep 17 00:00:00 2001
From: Michael Nikitochkin <miry.sof@gmail.com>
Date: Wed, 16 Dec 2015 00:45:24 +0100
Subject: [PATCH] AWS: Allow to configure master ip and services mask

Fix script for case when neeed to setup cluster
in an existen VPC and subnet with ip mask example: 10.0.0.0/8.

Fixed bug to detect ip of master if provided MASTER_RESERVED_IP.

For some reason detecting master ip was moved to volumes and only when MASTER_RESERVED_IP=auto.
If specify IPv4 for MASTER_RESERVED_IP like `52.1.1.1`, than we could
not detect ip even during last steps of setuping cluster.
step the KUBE_MASTER_IP is reseted because there are no tag for the
volume.
---
 cluster/aws/util.sh | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/cluster/aws/util.sh b/cluster/aws/util.sh
index e30721462d8..0717e7cd2f1 100755
--- a/cluster/aws/util.sh
+++ b/cluster/aws/util.sh
@@ -76,13 +76,15 @@ AWS_ASG_CMD="aws autoscaling"
 
 VPC_CIDR_BASE=172.20
 MASTER_IP_SUFFIX=.9
-MASTER_INTERNAL_IP=${VPC_CIDR_BASE}.0${MASTER_IP_SUFFIX}
 VPC_CIDR=${VPC_CIDR_BASE}.0.0/16
 SUBNET_CIDR=${VPC_CIDR_BASE}.0.0/24
 if [[ -n "${KUBE_SUBNET_CIDR:-}" ]]; then
   echo "Using subnet CIDR override: ${KUBE_SUBNET_CIDR}"
   SUBNET_CIDR=${KUBE_SUBNET_CIDR}
 fi
+if [[ -z "${MASTER_INTERNAL_IP-}" ]]; then
+  MASTER_INTERNAL_IP="${SUBNET_CIDR%.*}${MASTER_IP_SUFFIX}"
+fi
 
 MASTER_SG_NAME="kubernetes-master-${CLUSTER_ID}"
 NODE_SG_NAME="kubernetes-minion-${CLUSTER_ID}"
@@ -506,13 +508,13 @@ function ensure-master-ip {
     else
       KUBE_MASTER_IP=`$AWS_CMD allocate-address --domain vpc --query PublicIp`
       echo "Allocated Elastic IP for master: ${KUBE_MASTER_IP}"
-
-      # We can't tag elastic ips.  Instead we put the tag on the persistent disk.
-      # It is a little weird, perhaps, but it sort of makes sense...
-      # The master mounts the master PD, and whoever mounts the master PD should also
-      # have the master IP
-      add-tag ${MASTER_DISK_ID} ${TAG_KEY_MASTER_IP} ${KUBE_MASTER_IP}
     fi
+
+    # We can't tag elastic ips.  Instead we put the tag on the persistent disk.
+    # It is a little weird, perhaps, but it sort of makes sense...
+    # The master mounts the master PD, and whoever mounts the master PD should also
+    # have the master IP
+    add-tag ${MASTER_DISK_ID} ${TAG_KEY_MASTER_IP} ${KUBE_MASTER_IP}
   fi
 }
 
@@ -790,11 +792,10 @@ function subnet-setup {
   else
     EXISTING_CIDR=$($AWS_CMD describe-subnets --subnet-ids ${SUBNET_ID} --query Subnets[].CidrBlock)
     echo "Using existing subnet with CIDR $EXISTING_CIDR"
-    VPC_CIDR=$($AWS_CMD describe-vpcs --vpc-ids ${VPC_ID} --query Vpcs[].CidrBlock)
-    echo "VPC CIDR is $VPC_CIDR"
-    VPC_CIDR_BASE=${VPC_CIDR%.*.*}
-    MASTER_INTERNAL_IP=${VPC_CIDR_BASE}.0${MASTER_IP_SUFFIX}
-    echo "Assuming MASTER_INTERNAL_IP=${MASTER_INTERNAL_IP}"
+    if [ ! $SUBNET_CIDR = $EXISTING_CIDR ]; then
+      MASTER_INTERNAL_IP="${EXISTING_CIDR%.*}${MASTER_IP_SUFFIX}"
+      echo "Assuming MASTER_INTERNAL_IP=${MASTER_INTERNAL_IP}"
+    fi
   fi
 
   echo "Using subnet $SUBNET_ID"