From e51e5962d5a7372e155a82653a2f81f497b0215c Mon Sep 17 00:00:00 2001 From: Jongwoo Han Date: Wed, 3 May 2023 02:27:26 +0900 Subject: [PATCH] Use early return pattern to avoid nested conditions Signed-off-by: jongwooo --- pkg/kubelet/config/file_linux.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/kubelet/config/file_linux.go b/pkg/kubelet/config/file_linux.go index f672c962982..42d86f86872 100644 --- a/pkg/kubelet/config/file_linux.go +++ b/pkg/kubelet/config/file_linux.go @@ -140,14 +140,14 @@ func (s *sourceFile) consumeWatchEvent(e *watchEvent) error { pod, podExist, err := s.store.GetByKey(objKey) if err != nil { return err - } else if !podExist { - return fmt.Errorf("the pod with key %s doesn't exist in cache", objKey) - } else { - if err = s.store.Delete(pod); err != nil { - return fmt.Errorf("failed to remove deleted pod from cache: %v", err) - } - delete(s.fileKeyMapping, e.fileName) } + if !podExist { + return fmt.Errorf("the pod with key %s doesn't exist in cache", objKey) + } + if err = s.store.Delete(pod); err != nil { + return fmt.Errorf("failed to remove deleted pod from cache: %v", err) + } + delete(s.fileKeyMapping, e.fileName) } } return nil