From a37adceadf04e0aa039702ce93c972457d5d36c4 Mon Sep 17 00:00:00 2001
From: SataQiu <qiushida@beyondcent.com>
Date: Tue, 23 Apr 2019 23:26:41 +0800
Subject: [PATCH] fix golint failures of pkg/volume/portworx

---
 hack/.golint_failures                | 1 -
 pkg/volume/portworx/portworx.go      | 2 +-
 pkg/volume/portworx/portworx_util.go | 8 ++++----
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/hack/.golint_failures b/hack/.golint_failures
index adac8ddc34b..78bd47cb422 100644
--- a/hack/.golint_failures
+++ b/hack/.golint_failures
@@ -348,7 +348,6 @@ pkg/volume/host_path
 pkg/volume/iscsi
 pkg/volume/nfs
 pkg/volume/photon_pd
-pkg/volume/portworx
 pkg/volume/rbd
 pkg/volume/scaleio
 pkg/volume/storageos
diff --git a/pkg/volume/portworx/portworx.go b/pkg/volume/portworx/portworx.go
index 611447f7ae7..b1371e1c4c1 100644
--- a/pkg/volume/portworx/portworx.go
+++ b/pkg/volume/portworx/portworx.go
@@ -37,7 +37,7 @@ const (
 	attachHostKey    = "host"
 )
 
-// This is the primary entrypoint for volume plugins.
+// ProbeVolumePlugins is the primary entrypoint for volume plugins.
 func ProbeVolumePlugins() []volume.VolumePlugin {
 	return []volume.VolumePlugin{&portworxVolumePlugin{nil, nil}}
 }
diff --git a/pkg/volume/portworx/portworx_util.go b/pkg/volume/portworx/portworx_util.go
index a2fee466e13..d6bd04d8727 100644
--- a/pkg/volume/portworx/portworx_util.go
+++ b/pkg/volume/portworx/portworx_util.go
@@ -263,11 +263,11 @@ func createDriverClient(hostname string, port int32) (*osdclient.Client, error)
 		return nil, err
 	}
 
-	if isValid, err := isClientValid(client); isValid {
+	isValid, err := isClientValid(client)
+	if isValid {
 		return client, nil
-	} else {
-		return nil, err
 	}
+	return nil, err
 }
 
 // getPortworxDriver returns a Portworx volume driver which can be used for cluster wide operations.
@@ -365,7 +365,7 @@ func getPortworxService(host volume.VolumeHost) (*v1.Service, error) {
 	}
 
 	if svc == nil {
-		err = fmt.Errorf("Service: %v not found. Consult Portworx docs to deploy it.", pxServiceName)
+		err = fmt.Errorf("Service: %v not found. Consult Portworx docs to deploy it", pxServiceName)
 		klog.Errorf(err.Error())
 		return nil, err
 	}