From d6519150ca4929cc28df87135274e1d64088163d Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 14 Sep 2021 10:33:05 +0200 Subject: [PATCH] component-base: verbosity in example command The global klog flags were not enabled (an oversight?). Once they get added, logging at different verbosity levels can be demonstrated. --- .../component-base/logs/example/README.md | 17 +++++++++++++++++ .../component-base/logs/example/cmd/logger.go | 1 + 2 files changed, 18 insertions(+) diff --git a/staging/src/k8s.io/component-base/logs/example/README.md b/staging/src/k8s.io/component-base/logs/example/README.md index c1b7b3785be..b70a5cf931b 100644 --- a/staging/src/k8s.io/component-base/logs/example/README.md +++ b/staging/src/k8s.io/component-base/logs/example/README.md @@ -50,3 +50,20 @@ E0605 22:04:02.019698 3229645 logger.go:61] Log using Errorf, err: fail E0605 22:04:02.019709 3229645 logger.go:62] "Log using ErrorS" err="fail" I0605 22:04:02.019714 3229645 logger.go:64] Log message has been redacted. Log argument #0 contains: [secret-key] ``` + +## Verbosity + +```console +go run ./staging/src/k8s.io/component-base/logs/example/cmd/logger.go -v1 +``` + +``` +I0914 10:31:12.342958 54086 logger.go:61] Log using Infof, key: value +I0914 10:31:12.343021 54086 logger.go:62] "Log using InfoS" key="value" +E0914 10:31:12.343053 54086 logger.go:64] Log using Errorf, err: fail +E0914 10:31:12.343064 54086 logger.go:65] "Log using ErrorS" err="fail" +I0914 10:31:12.343073 54086 logger.go:67] Log with sensitive key, data: {"secret"} +I0914 10:31:12.343090 54086 logger.go:68] Log less important message +``` + +The last line is not printed at the default log level. diff --git a/staging/src/k8s.io/component-base/logs/example/cmd/logger.go b/staging/src/k8s.io/component-base/logs/example/cmd/logger.go index c3ee30f1082..f3d8e7c9dbb 100644 --- a/staging/src/k8s.io/component-base/logs/example/cmd/logger.go +++ b/staging/src/k8s.io/component-base/logs/example/cmd/logger.go @@ -61,6 +61,7 @@ func runLogger() { klog.ErrorS(err, "Log using ErrorS") data := SensitiveData{Key: "secret"} klog.Infof("Log with sensitive key, data: %q", data) + klog.V(1).Info("Log less important message") } type SensitiveData struct {