Merge pull request #114992 from TheOneTheOnlyJJ/skip-failing-unittests-2

Skip failing Windows unit tests (volume)

pkg/volume/downwardapi/downwardapi_test.go

@@ -21,6 +21,7 @@ import (
 	"io/ioutil"
 	"os"
 	"path/filepath"
+	"runtime"
 	"testing"
 
 	"k8s.io/api/core/v1"
@@ -72,6 +73,11 @@ func TestCanSupport(t *testing.T) {
 }
 
 func TestDownwardAPI(t *testing.T) {
+	// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
+	if runtime.GOOS == "windows" {
+		t.Skip("Skipping test that fails on Windows")
+	}
+
 	labels1 := map[string]string{
 		"key1": "value1",
 		"key2": "value2",

pkg/volume/flexvolume/probe_test.go

@@ -72,6 +72,11 @@ func TestProberExistingDriverBeforeInit(t *testing.T) {
 
 // Probes newly added drivers after prober is running.
 func TestProberAddRemoveDriver(t *testing.T) {
+	// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
+	if goruntime.GOOS == "windows" {
+		t.Skip("Skipping test that fails on Windows")
+	}
+
 	// Arrange
 	_, fs, watcher, prober := initTestEnvironment(t)
 	prober.Probe()
@@ -205,6 +210,11 @@ func TestEmptyPluginDir(t *testing.T) {
 
 // Issue an event to remove plugindir. New directory should still be watched.
 func TestRemovePluginDir(t *testing.T) {
+	// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
+	if goruntime.GOOS == "windows" {
+		t.Skip("Skipping test that fails on Windows")
+	}
+
 	// Arrange
 	driverPath, fs, watcher, _ := initTestEnvironment(t)
 	err := fs.RemoveAll(pluginDir)
@@ -226,6 +236,11 @@ func TestRemovePluginDir(t *testing.T) {
 
 // Issue an event to remove plugindir. New directory should still be watched.
 func TestNestedDriverDir(t *testing.T) {
+	// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
+	if goruntime.GOOS == "windows" {
+		t.Skip("Skipping test that fails on Windows")
+	}
+
 	// Arrange
 	_, fs, watcher, _ := initTestEnvironment(t)
 	// Assert

pkg/volume/local/local_test.go

@@ -244,6 +244,11 @@ func TestInvalidLocalPath(t *testing.T) {
 }
 
 func TestBlockDeviceGlobalPathAndMountDevice(t *testing.T) {
+	// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
+	if runtime.GOOS == "windows" {
+		t.Skip("Skipping test that fails on Windows")
+	}
+
 	// Block device global mount path testing
 	tmpBlockDir, plug := getDeviceMountablePluginWithBlockPath(t, true)
 	defer os.RemoveAll(tmpBlockDir)

pkg/volume/rbd/rbd_test.go

@@ -359,6 +359,11 @@ type testcase struct {
 }
 
 func TestPlugin(t *testing.T) {
+	// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
+	if runtime.GOOS == "windows" {
+		t.Skip("Skipping test that fails on Windows")
+	}
+
 	tmpDir, err := utiltesting.MkTmpdir("rbd_test")
 	if err != nil {
 		t.Fatalf("error creating temp dir: %v", err)

pkg/volume/util/hostutil/hostutil_test.go

@@ -119,6 +119,11 @@ func createSocketFile(socketDir string) (string, error) {
 }
 
 func TestGetFileType(t *testing.T) {
+	// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
+	if goruntime.GOOS == "windows" {
+		t.Skip("Skipping test that fails on Windows")
+	}
+
 	hu := NewHostUtil()
 
 	testCase := []struct {