Only default Job fields when feature gates are enabled

Also use pointer for completionMode enum

pkg/apis/batch/v1/defaults_test.go

@@ -25,9 +25,12 @@ import (
 	"k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apiserver/pkg/util/feature"
+	featuregatetesting "k8s.io/component-base/featuregate/testing"
 	"k8s.io/kubernetes/pkg/api/legacyscheme"
 	_ "k8s.io/kubernetes/pkg/apis/batch/install"
 	_ "k8s.io/kubernetes/pkg/apis/core/install"
+	"k8s.io/kubernetes/pkg/features"
 	"k8s.io/utils/pointer"
 
 	. "k8s.io/kubernetes/pkg/apis/batch/v1"
@@ -36,9 +39,11 @@ import (
 func TestSetDefaultJob(t *testing.T) {
 	defaultLabels := map[string]string{"default": "default"}
 	tests := map[string]struct {
-		original     *batchv1.Job
-		expected     *batchv1.Job
-		expectLabels bool
+		indexedJobEnabled bool
+		suspendJobEnabled bool
+		original          *batchv1.Job
+		expected          *batchv1.Job
+		expectLabels      bool
 	}{
 		"All unspecified -> sets all to default values": {
 			original: &batchv1.Job{
@@ -50,19 +55,17 @@ func TestSetDefaultJob(t *testing.T) {
 			},
 			expected: &batchv1.Job{
 				Spec: batchv1.JobSpec{
-					Completions:    pointer.Int32Ptr(1),
-					Parallelism:    pointer.Int32Ptr(1),
-					BackoffLimit:   pointer.Int32Ptr(6),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(false),
+					Completions:  pointer.Int32Ptr(1),
+					Parallelism:  pointer.Int32Ptr(1),
+					BackoffLimit: pointer.Int32Ptr(6),
 				},
 			},
 			expectLabels: true,
 		},
-		"suspend set, everything else is defaulted": {
+		"All unspecified, indexed job enabled -> sets all to default values": {
+			indexedJobEnabled: true,
 			original: &batchv1.Job{
 				Spec: batchv1.JobSpec{
-					Suspend: pointer.BoolPtr(true),
 					Template: v1.PodTemplateSpec{
 						ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
 					},
@@ -73,13 +76,51 @@ func TestSetDefaultJob(t *testing.T) {
 					Completions:    pointer.Int32Ptr(1),
 					Parallelism:    pointer.Int32Ptr(1),
 					BackoffLimit:   pointer.Int32Ptr(6),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(true),
+					CompletionMode: completionModePtr(batchv1.NonIndexedCompletion),
 				},
 			},
 			expectLabels: true,
 		},
-		"All unspecified -> all pointers, CompletionMode are defaulted and no default labels": {
+		"All unspecified, suspend job enabled -> sets all to default values": {
+			suspendJobEnabled: true,
+			original: &batchv1.Job{
+				Spec: batchv1.JobSpec{
+					Template: v1.PodTemplateSpec{
+						ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
+					},
+				},
+			},
+			expected: &batchv1.Job{
+				Spec: batchv1.JobSpec{
+					Completions:  pointer.Int32Ptr(1),
+					Parallelism:  pointer.Int32Ptr(1),
+					BackoffLimit: pointer.Int32Ptr(6),
+					Suspend:      pointer.BoolPtr(false),
+				},
+			},
+			expectLabels: true,
+		},
+		"suspend set, everything else is defaulted": {
+			suspendJobEnabled: true,
+			original: &batchv1.Job{
+				Spec: batchv1.JobSpec{
+					Suspend: pointer.BoolPtr(true),
+					Template: v1.PodTemplateSpec{
+						ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
+					},
+				},
+			},
+			expected: &batchv1.Job{
+				Spec: batchv1.JobSpec{
+					Completions:  pointer.Int32Ptr(1),
+					Parallelism:  pointer.Int32Ptr(1),
+					BackoffLimit: pointer.Int32Ptr(6),
+					Suspend:      pointer.BoolPtr(true),
+				},
+			},
+			expectLabels: true,
+		},
+		"All unspecified -> all pointers are defaulted and no default labels": {
 			original: &batchv1.Job{
 				ObjectMeta: metav1.ObjectMeta{
 					Labels: map[string]string{"mylabel": "myvalue"},
@@ -92,11 +133,9 @@ func TestSetDefaultJob(t *testing.T) {
 			},
 			expected: &batchv1.Job{
 				Spec: batchv1.JobSpec{
-					Completions:    pointer.Int32Ptr(1),
-					Parallelism:    pointer.Int32Ptr(1),
-					BackoffLimit:   pointer.Int32Ptr(6),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(false),
+					Completions:  pointer.Int32Ptr(1),
+					Parallelism:  pointer.Int32Ptr(1),
+					BackoffLimit: pointer.Int32Ptr(6),
 				},
 			},
 		},
@@ -111,10 +150,8 @@ func TestSetDefaultJob(t *testing.T) {
 			},
 			expected: &batchv1.Job{
 				Spec: batchv1.JobSpec{
-					Parallelism:    pointer.Int32Ptr(0),
-					BackoffLimit:   pointer.Int32Ptr(6),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(false),
+					Parallelism:  pointer.Int32Ptr(0),
+					BackoffLimit: pointer.Int32Ptr(6),
 				},
 			},
 			expectLabels: true,
@@ -130,10 +167,8 @@ func TestSetDefaultJob(t *testing.T) {
 			},
 			expected: &batchv1.Job{
 				Spec: batchv1.JobSpec{
-					Parallelism:    pointer.Int32Ptr(2),
-					BackoffLimit:   pointer.Int32Ptr(6),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(false),
+					Parallelism:  pointer.Int32Ptr(2),
+					BackoffLimit: pointer.Int32Ptr(6),
 				},
 			},
 			expectLabels: true,
@@ -149,11 +184,9 @@ func TestSetDefaultJob(t *testing.T) {
 			},
 			expected: &batchv1.Job{
 				Spec: batchv1.JobSpec{
-					Completions:    pointer.Int32Ptr(2),
-					Parallelism:    pointer.Int32Ptr(1),
-					BackoffLimit:   pointer.Int32Ptr(6),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(false),
+					Completions:  pointer.Int32Ptr(2),
+					Parallelism:  pointer.Int32Ptr(1),
+					BackoffLimit: pointer.Int32Ptr(6),
 				},
 			},
 			expectLabels: true,
@@ -169,11 +202,9 @@ func TestSetDefaultJob(t *testing.T) {
 			},
 			expected: &batchv1.Job{
 				Spec: batchv1.JobSpec{
-					Completions:    pointer.Int32Ptr(1),
-					Parallelism:    pointer.Int32Ptr(1),
-					BackoffLimit:   pointer.Int32Ptr(5),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(false),
+					Completions:  pointer.Int32Ptr(1),
+					Parallelism:  pointer.Int32Ptr(1),
+					BackoffLimit: pointer.Int32Ptr(5),
 				},
 			},
 			expectLabels: true,
@@ -184,8 +215,8 @@ func TestSetDefaultJob(t *testing.T) {
 					Completions:    pointer.Int32Ptr(8),
 					Parallelism:    pointer.Int32Ptr(9),
 					BackoffLimit:   pointer.Int32Ptr(10),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(true),
+					CompletionMode: completionModePtr(batchv1.NonIndexedCompletion),
+					Suspend:        pointer.BoolPtr(false),
 					Template: v1.PodTemplateSpec{
 						ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
 					},
@@ -196,8 +227,8 @@ func TestSetDefaultJob(t *testing.T) {
 					Completions:    pointer.Int32Ptr(8),
 					Parallelism:    pointer.Int32Ptr(9),
 					BackoffLimit:   pointer.Int32Ptr(10),
-					CompletionMode: batchv1.NonIndexedCompletion,
-					Suspend:        pointer.BoolPtr(true),
+					CompletionMode: completionModePtr(batchv1.NonIndexedCompletion),
+					Suspend:        pointer.BoolPtr(false),
 					Template: v1.PodTemplateSpec{
 						ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
 					},
@@ -211,7 +242,7 @@ func TestSetDefaultJob(t *testing.T) {
 					Completions:    pointer.Int32Ptr(11),
 					Parallelism:    pointer.Int32Ptr(10),
 					BackoffLimit:   pointer.Int32Ptr(9),
-					CompletionMode: batchv1.IndexedCompletion,
+					CompletionMode: completionModePtr(batchv1.IndexedCompletion),
 					Suspend:        pointer.BoolPtr(true),
 					Template: v1.PodTemplateSpec{
 						ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
@@ -223,7 +254,7 @@ func TestSetDefaultJob(t *testing.T) {
 					Completions:    pointer.Int32Ptr(11),
 					Parallelism:    pointer.Int32Ptr(10),
 					BackoffLimit:   pointer.Int32Ptr(9),
-					CompletionMode: batchv1.IndexedCompletion,
+					CompletionMode: completionModePtr(batchv1.IndexedCompletion),
 					Suspend:        pointer.BoolPtr(true),
 				},
 			},
@@ -233,6 +264,8 @@ func TestSetDefaultJob(t *testing.T) {
 
 	for name, test := range tests {
 		t.Run(name, func(t *testing.T) {
+			defer featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.IndexedJob, test.indexedJobEnabled)()
+			defer featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.SuspendJob, test.suspendJobEnabled)()
 
 			original := test.original
 			expected := test.expected
@@ -256,8 +289,8 @@ func TestSetDefaultJob(t *testing.T) {
 					t.Errorf("Unexpected equality: %v", actual.Labels)
 				}
 			}
-			if actual.Spec.CompletionMode != expected.Spec.CompletionMode {
-				t.Errorf("Got CompletionMode: %v, want: %v", actual.Spec.CompletionMode, expected.Spec.CompletionMode)
+			if diff := cmp.Diff(expected.Spec.CompletionMode, actual.Spec.CompletionMode); diff != "" {
+				t.Errorf("Unexpected CompletionMode (-want,+got):\n%s", diff)
 			}
 		})
 	}
@@ -304,7 +337,7 @@ func TestSetDefaultCronJob(t *testing.T) {
 			expected: &batchv1.CronJob{
 				Spec: batchv1.CronJobSpec{
 					ConcurrencyPolicy:          batchv1.AllowConcurrent,
-					Suspend:                    newBool(false),
+					Suspend:                    pointer.BoolPtr(false),
 					SuccessfulJobsHistoryLimit: pointer.Int32Ptr(3),
 					FailedJobsHistoryLimit:     pointer.Int32Ptr(1),
 				},
@@ -314,7 +347,7 @@ func TestSetDefaultCronJob(t *testing.T) {
 			original: &batchv1.CronJob{
 				Spec: batchv1.CronJobSpec{
 					ConcurrencyPolicy:          batchv1.ForbidConcurrent,
-					Suspend:                    newBool(true),
+					Suspend:                    pointer.BoolPtr(true),
 					SuccessfulJobsHistoryLimit: pointer.Int32Ptr(5),
 					FailedJobsHistoryLimit:     pointer.Int32Ptr(5),
 				},
@@ -322,7 +355,7 @@ func TestSetDefaultCronJob(t *testing.T) {
 			expected: &batchv1.CronJob{
 				Spec: batchv1.CronJobSpec{
 					ConcurrencyPolicy:          batchv1.ForbidConcurrent,
-					Suspend:                    newBool(true),
+					Suspend:                    pointer.BoolPtr(true),
 					SuccessfulJobsHistoryLimit: pointer.Int32Ptr(5),
 					FailedJobsHistoryLimit:     pointer.Int32Ptr(5),
 				},
@@ -354,8 +387,6 @@ func TestSetDefaultCronJob(t *testing.T) {
 	}
 }
 
-func newBool(val bool) *bool {
-	p := new(bool)
-	*p = val
-	return p
+func completionModePtr(m batchv1.CompletionMode) *batchv1.CompletionMode {
+	return &m
 }