From 287f703d3abe00a41b830167ea2a55d62e738e8c Mon Sep 17 00:00:00 2001 From: FengyunPan Date: Mon, 22 May 2017 21:51:11 +0800 Subject: [PATCH] Close file after os.Open() --- test/e2e/e2e.go | 1 + test/e2e/kubectl.go | 1 + test/e2e_node/node_problem_detector_linux.go | 1 + 3 files changed, 3 insertions(+) diff --git a/test/e2e/e2e.go b/test/e2e/e2e.go index 5df6943cea6..2456538e164 100644 --- a/test/e2e/e2e.go +++ b/test/e2e/e2e.go @@ -95,6 +95,7 @@ func setupProviderConfig() error { framework.Logf("Couldn't open cloud provider configuration %s: %#v", cloudConfig.ConfigFile, err) } + defer config.Close() cloudConfig.Provider, err = azure.NewCloud(config) } diff --git a/test/e2e/kubectl.go b/test/e2e/kubectl.go index 0935b4bb340..961f3f3e0e4 100644 --- a/test/e2e/kubectl.go +++ b/test/e2e/kubectl.go @@ -2013,6 +2013,7 @@ func newStreamingUpload(filePath string) (*io.PipeReader, *multipart.Writer, err if err != nil { return nil, nil, err } + defer file.Close() r, w := io.Pipe() diff --git a/test/e2e_node/node_problem_detector_linux.go b/test/e2e_node/node_problem_detector_linux.go index 65136495295..7e2722b70e4 100644 --- a/test/e2e_node/node_problem_detector_linux.go +++ b/test/e2e_node/node_problem_detector_linux.go @@ -372,6 +372,7 @@ func injectLog(file string, timestamp time.Time, log string, num int) error { if err != nil { return err } + defer f.Close() for i := 0; i < num; i++ { _, err := f.WriteString(fmt.Sprintf("%s kernel: [0.000000] %s\n", timestamp.Format(time.Stamp), log)) if err != nil {